aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
diff options
context:
space:
mode:
authorbrainopia <brainopia@evilmartians.com>2015-01-08 02:53:57 +0300
committerbrainopia <brainopia@evilmartians.com>2015-01-08 02:53:57 +0300
commitf9e2496872bcd34aa7c6083b1763322b47fba6a3 (patch)
treeb0a058a64fa84f92b8943260d7cb7b8116c98cc1 /actionpack
parent5d28c6b5b8407abf9274f78502d387c98f209286 (diff)
downloadrails-f9e2496872bcd34aa7c6083b1763322b47fba6a3.tar.gz
rails-f9e2496872bcd34aa7c6083b1763322b47fba6a3.tar.bz2
rails-f9e2496872bcd34aa7c6083b1763322b47fba6a3.zip
Correct route requirements by overriding defaultls (fixes #18373)
Diffstat (limited to 'actionpack')
-rw-r--r--actionpack/lib/action_dispatch/journey/route.rb2
-rw-r--r--actionpack/test/journey/route_test.rb8
2 files changed, 9 insertions, 1 deletions
diff --git a/actionpack/lib/action_dispatch/journey/route.rb b/actionpack/lib/action_dispatch/journey/route.rb
index 4d5c18984a..4698ff8cc7 100644
--- a/actionpack/lib/action_dispatch/journey/route.rb
+++ b/actionpack/lib/action_dispatch/journey/route.rb
@@ -36,7 +36,7 @@ module ActionDispatch
def requirements # :nodoc:
# needed for rails `rake routes`
- path.requirements.merge(@defaults).delete_if { |_,v|
+ @defaults.merge(path.requirements).delete_if { |_,v|
/.+?/ == v
}
end
diff --git a/actionpack/test/journey/route_test.rb b/actionpack/test/journey/route_test.rb
index 21d867aca0..9616f036b3 100644
--- a/actionpack/test/journey/route_test.rb
+++ b/actionpack/test/journey/route_test.rb
@@ -25,6 +25,14 @@ module ActionDispatch
end
end
+ def test_path_requirements_override_defaults
+ strexp = Router::Strexp.build(':name', { name: /love/ }, ['/'])
+ path = Path::Pattern.new strexp
+ defaults = { name: 'tender' }
+ route = Route.new('name', nil, path, nil, defaults)
+ assert_equal /love/, route.requirements[:name]
+ end
+
def test_ip_address
path = Path::Pattern.from_string '/messages/:id(.:format)'
route = Route.new("name", nil, path, {:ip => '192.168.1.1'},