diff options
author | schneems <richard.schneeman@gmail.com> | 2013-01-18 15:26:13 -0600 |
---|---|---|
committer | schneems <richard.schneeman@gmail.com> | 2013-01-18 15:41:19 -0600 |
commit | f654c3cfc00271c3b410bc0fe9c80a5593709c02 (patch) | |
tree | f2205877d945ea60c12cc84072d335f63646df51 /actionpack | |
parent | 40e797827935756aacf0463e4b44e1c1c92b0aeb (diff) | |
download | rails-f654c3cfc00271c3b410bc0fe9c80a5593709c02.tar.gz rails-f654c3cfc00271c3b410bc0fe9c80a5593709c02.tar.bz2 rails-f654c3cfc00271c3b410bc0fe9c80a5593709c02.zip |
Remove "Application" section title from routes
This PR standardizes the output of the HTML and console based routes to not include the title for "Application Routes" those that are defined by the application. Instead only routes defined in engines get any special treatment.
Based on this conversation:
https://github.com/rails/rails/commit/af5c0fd85fce1adb311083dd1ecf96432ee8caa3#commitcomment-2458823
ATP actionpack /cc @carlosantoniodasilva
Diffstat (limited to 'actionpack')
-rw-r--r-- | actionpack/lib/action_dispatch/routing/inspector.rb | 19 |
1 files changed, 13 insertions, 6 deletions
diff --git a/actionpack/lib/action_dispatch/routing/inspector.rb b/actionpack/lib/action_dispatch/routing/inspector.rb index ea3e8357d4..474d43cd67 100644 --- a/actionpack/lib/action_dispatch/routing/inspector.rb +++ b/actionpack/lib/action_dispatch/routing/inspector.rb @@ -73,10 +73,11 @@ module ActionDispatch routes_to_display = filter_routes(filter) routes = collect_routes(routes_to_display) - formatter.section :application, 'Application routes', routes + formatter.section routes @engines.each do |name, engine_routes| - formatter.section :engine, "Routes for #{name}", engine_routes + formatter.section_title "Routes for #{name}" + formatter.section engine_routes end formatter.result @@ -125,8 +126,11 @@ module ActionDispatch @buffer.join("\n") end - def section(type, title, routes) - @buffer << "\n#{title}:" unless type == :application + def section_title(title) + @buffer << "\n#{title}:" + end + + def section(routes) @buffer << draw_section(routes) end @@ -148,8 +152,11 @@ module ActionDispatch @buffer = [] end - def section(type, title, routes) - @buffer << %(<tr><th colspan="4">#{title}</th></tr>) + def section_title(title) + @buffer << "<tr><th colspan="4">#{title}</th></tr>" + end + + def section(routes) @buffer << @view.render(partial: "routes/route", collection: routes) end |