diff options
author | Jeremy Kemper <jeremy@bitsweat.net> | 2008-01-06 20:52:57 +0000 |
---|---|---|
committer | Jeremy Kemper <jeremy@bitsweat.net> | 2008-01-06 20:52:57 +0000 |
commit | ca4c7ab362d0110bfade496ca66b30bafdb7f25e (patch) | |
tree | e5a968b9dca4c2ad2f5d936c693286a548c4702f /actionpack | |
parent | 523658c1dffc6d125898caac6bf43118fbb3e27e (diff) | |
download | rails-ca4c7ab362d0110bfade496ca66b30bafdb7f25e.tar.gz rails-ca4c7ab362d0110bfade496ca66b30bafdb7f25e.tar.bz2 rails-ca4c7ab362d0110bfade496ca66b30bafdb7f25e.zip |
Support render :text => nil. Closes #6684.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8577 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
Diffstat (limited to 'actionpack')
-rw-r--r-- | actionpack/CHANGELOG | 2 | ||||
-rwxr-xr-x | actionpack/lib/action_controller/base.rb | 4 | ||||
-rw-r--r-- | actionpack/test/controller/render_test.rb | 19 |
3 files changed, 23 insertions, 2 deletions
diff --git a/actionpack/CHANGELOG b/actionpack/CHANGELOG index e6fabd27fc..c2af2c8c11 100644 --- a/actionpack/CHANGELOG +++ b/actionpack/CHANGELOG @@ -1,5 +1,7 @@ *SVN* +* Support render :text => nil. #6684 [tjennings, PotatoSalad, Cheah Chu Yeow] + * assert_response failures include the exception message. #10688 [Seth Rasmussen] * All fragment cache keys are now by default prefixed with the "views/" namespace [DHH] diff --git a/actionpack/lib/action_controller/base.rb b/actionpack/lib/action_controller/base.rb index 3818960979..d419a09ec5 100755 --- a/actionpack/lib/action_controller/base.rb +++ b/actionpack/lib/action_controller/base.rb @@ -850,8 +850,8 @@ module ActionController #:nodoc: response.headers["Location"] = url_for(location) end - if text = options[:text] - render_for_text(text, options[:status]) + if options.has_key?(:text) + render_for_text(options[:text], options[:status]) else if file = options[:file] diff --git a/actionpack/test/controller/render_test.rb b/actionpack/test/controller/render_test.rb index 1d83b37658..ddb77ee6b2 100644 --- a/actionpack/test/controller/render_test.rb +++ b/actionpack/test/controller/render_test.rb @@ -57,6 +57,14 @@ class TestController < ActionController::Base render :text => "hello world", :status => 404 end + def render_text_with_nil + render :text => nil + end + + def render_text_with_false + render :text => false + end + def render_nothing_with_appendix render :text => "appended" end @@ -263,6 +271,17 @@ class RenderTest < Test::Unit::TestCase assert_equal 'hello world', @response.body end + def test_render_text_with_nil + get :render_text_with_nil + assert_response 200 + assert_equal '', @response.body + end + + def test_render_text_with_false + get :render_text_with_false + assert_equal 'false', @response.body + end + def test_render_nothing_with_appendix get :render_nothing_with_appendix assert_response 200 |