diff options
author | Gustavo Gutierrez <gustavogut1993@gmail.com> | 2019-05-17 15:13:03 +0200 |
---|---|---|
committer | Gustavo Gutierrez <gustavogut1993@gmail.com> | 2019-05-22 16:04:31 +0200 |
commit | bc7e94503a3fb30d6e02898fc2d08285eb0b552b (patch) | |
tree | 292c84d471ecd6570e2ba4e04cddb410b6617acb /actionpack | |
parent | 206cee578a915fe5199bac2a83c99f828bd77132 (diff) | |
download | rails-bc7e94503a3fb30d6e02898fc2d08285eb0b552b.tar.gz rails-bc7e94503a3fb30d6e02898fc2d08285eb0b552b.tar.bz2 rails-bc7e94503a3fb30d6e02898fc2d08285eb0b552b.zip |
Implemented deep_transform_keys/! for ActionController::Parameters
Diffstat (limited to 'actionpack')
-rw-r--r-- | actionpack/CHANGELOG.md | 4 | ||||
-rw-r--r-- | actionpack/lib/action_controller/metal/strong_parameters.rb | 17 | ||||
-rw-r--r-- | actionpack/test/controller/parameters/accessors_test.rb | 9 | ||||
-rw-r--r-- | actionpack/test/controller/parameters/mutators_test.rb | 9 |
4 files changed, 39 insertions, 0 deletions
diff --git a/actionpack/CHANGELOG.md b/actionpack/CHANGELOG.md index 32721ac233..a84f72eca9 100644 --- a/actionpack/CHANGELOG.md +++ b/actionpack/CHANGELOG.md @@ -1,3 +1,7 @@ +* Added `deep_transform_keys` and `deep_transform_keys!` methods to ActionController::Parameters. + + *Gustavo Gutierrez* + * Calling `ActionController::Parameters#transform_keys/!` without a block now returns an enumerator for the parameters instead of the underlying hash. diff --git a/actionpack/lib/action_controller/metal/strong_parameters.rb b/actionpack/lib/action_controller/metal/strong_parameters.rb index 016a633f71..6a07a73d94 100644 --- a/actionpack/lib/action_controller/metal/strong_parameters.rb +++ b/actionpack/lib/action_controller/metal/strong_parameters.rb @@ -693,6 +693,23 @@ module ActionController self end + # Returns a new <tt>ActionController::Parameters</tt> instance with the + # results of running +block+ once for every key. This includes the keys + # from the root hash and from all nested hashes and arrays. The values are unchanged. + def deep_transform_keys(&block) + new_instance_with_inherited_permitted_status( + @parameters.deep_transform_keys(&block) + ) + end + + # Returns the <tt>ActionController::Parameters</tt> instance changing its keys. + # This includes the keys from the root hash and from all nested hashes and arrays. + # The values are unchanged. + def deep_transform_keys!(&block) + @parameters.deep_transform_keys!(&block) + self + end + # Deletes a key-value pair from +Parameters+ and returns the value. If # +key+ is not found, returns +nil+ (or, with optional code block, yields # +key+ and returns the result). Cf. +#extract!+, which returns the diff --git a/actionpack/test/controller/parameters/accessors_test.rb b/actionpack/test/controller/parameters/accessors_test.rb index 7b9b716a42..cb49eeb1b7 100644 --- a/actionpack/test/controller/parameters/accessors_test.rb +++ b/actionpack/test/controller/parameters/accessors_test.rb @@ -213,6 +213,15 @@ class ParametersAccessorsTest < ActiveSupport::TestCase assert_kind_of ActionController::Parameters, @params.transform_keys!.each { |k| k } end + test "deep_transform_keys retains permitted status" do + @params.permit! + assert_predicate @params.deep_transform_keys { |k| k }, :permitted? + end + + test "deep_transform_keys retains unpermitted status" do + assert_not_predicate @params.deep_transform_keys { |k| k }, :permitted? + end + test "transform_values retains permitted status" do @params.permit! assert_predicate @params.transform_values { |v| v }, :permitted? diff --git a/actionpack/test/controller/parameters/mutators_test.rb b/actionpack/test/controller/parameters/mutators_test.rb index 312b1e5b27..31ee7964f5 100644 --- a/actionpack/test/controller/parameters/mutators_test.rb +++ b/actionpack/test/controller/parameters/mutators_test.rb @@ -118,4 +118,13 @@ class ParametersMutatorsTest < ActiveSupport::TestCase test "transform_values! retains unpermitted status" do assert_not_predicate @params.transform_values! { |v| v }, :permitted? end + + test "deep_transform_keys! retains permitted status" do + @params.permit! + assert_predicate @params.deep_transform_keys! { |k| k }, :permitted? + end + + test "deep_transform_keys! retains unpermitted status" do + assert_not_predicate @params.deep_transform_keys! { |k| k }, :permitted? + end end |