Change `SystemTestCase.driven_by` to use `setup`/`teardown` hooks

Previously, `driven_by` would change the Capybara configuration when
the test case is loaded, and having multiple test classes with different
`driven_by` configs would fail as the last loaded would be effective.

4 files changed, 35 insertions, 27 deletions

diff --git a/actionpack/lib/action_dispatch/system_test_case.rb b/actionpack/lib/action_dispatch/system_test_case.rb
index 70a5b75781..d6388d8fb7 100644
--- a/actionpack/lib/action_dispatch/system_test_case.rb
+++ b/actionpack/lib/action_dispatch/system_test_case.rb
@@ -105,9 +105,16 @@ module ActionDispatch
     #
     #   driven_by :selenium, screen_size: [800, 800]
     def self.driven_by(driver, using: :chrome, screen_size: [1400, 1400])
-      SystemTesting::Driver.new(driver).run
+      driver = if selenium?(driver)
+                 SystemTesting::Browser.new(using, screen_size)
+               else
+                 SystemTesting::Driver.new(driver)
+               end
+
+      setup { driver.use }
+      teardown { driver.reset }
+
       SystemTesting::Server.new.run
-      SystemTesting::Browser.new(using, screen_size).run if selenium?(driver)
     end
 
     def self.selenium?(driver) # :nodoc:
diff --git a/actionpack/lib/action_dispatch/system_testing/browser.rb b/actionpack/lib/action_dispatch/system_testing/browser.rb
index c9a6628516..14ea06459d 100644
--- a/actionpack/lib/action_dispatch/system_testing/browser.rb
+++ b/actionpack/lib/action_dispatch/system_testing/browser.rb
@@ -1,14 +1,17 @@
+require "action_dispatch/system_testing/driver"
+
 module ActionDispatch
   module SystemTesting
-    class Browser # :nodoc:
+    class Browser < Driver # :nodoc:
       def initialize(name, screen_size)
+        super(name)
         @name = name
         @screen_size = screen_size
       end
 
-      def run
+      def use
         register
-        setup
+        super
       end
 
       private
@@ -19,10 +22,6 @@ module ActionDispatch
             end
           end
         end
-
-        def setup
-          Capybara.default_driver = @name.to_sym
-        end
     end
   end
 end
diff --git a/actionpack/lib/action_dispatch/system_testing/driver.rb b/actionpack/lib/action_dispatch/system_testing/driver.rb
index 7c2ad84e19..8decb54419 100644
--- a/actionpack/lib/action_dispatch/system_testing/driver.rb
+++ b/actionpack/lib/action_dispatch/system_testing/driver.rb
@@ -5,14 +5,14 @@ module ActionDispatch
         @name = name
       end
 
-      def run
-        register
+      def use
+        @current = Capybara.current_driver
+        Capybara.current_driver = @name
       end
 
-      private
-        def register
-          Capybara.default_driver = @name
-        end
+      def reset
+        Capybara.current_driver = @current
+      end
     end
   end
 end
diff --git a/actionpack/test/dispatch/system_testing/system_test_case_test.rb b/actionpack/test/dispatch/system_testing/system_test_case_test.rb
index a384902a14..ff01d6739a 100644
--- a/actionpack/test/dispatch/system_testing/system_test_case_test.rb
+++ b/actionpack/test/dispatch/system_testing/system_test_case_test.rb
@@ -1,21 +1,23 @@
 require "abstract_unit"
 
-class SystemTestCaseTest < ActiveSupport::TestCase
-  test "driven_by sets Capybara's default driver to poltergeist" do
-    ActionDispatch::SystemTestCase.driven_by :poltergeist
-
-    assert_equal :poltergeist, Capybara.default_driver
+class DrivenByCaseTestTest < ActiveSupport::TestCase
+  test "selenium? returns false if driver is poltergeist" do
+    assert_not ActionDispatch::SystemTestCase.selenium?(:poltergeist)
   end
+end
 
-  test "driven_by sets Capybara's drivers respectively" do
-    ActionDispatch::SystemTestCase.driven_by :selenium, using: :chrome
+class DrivenByRackTestTest < ActionDispatch::SystemTestCase
+  driven_by :rack_test
 
-    assert_includes Capybara.drivers, :selenium
-    assert_includes Capybara.drivers, :chrome
-    assert_equal :chrome, Capybara.default_driver
+  test "uses rack_test" do
+    assert_equal :rack_test, Capybara.current_driver
   end
+end
 
-  test "selenium? returns false if driver is poltergeist" do
-    assert_not ActionDispatch::SystemTestCase.selenium?(:poltergeist)
+class DrivenBySeleniumWithChromeTest < ActionDispatch::SystemTestCase
+  driven_by :selenium, using: :chrome
+
+  test "uses selenium" do
+    assert_equal :chrome, Capybara.current_driver
   end
 end