diff options
| author | utilum <oz@utilum.com> | 2018-02-22 00:40:21 +0100 |
|---|---|---|
| committer | utilum <oz@utilum.com> | 2018-02-22 00:54:40 +0100 |
| commit | 6f6fe69ea8d2072c49ab7d56b32f19ea27805962 (patch) | |
| tree | bdd0e484b93d216b590c435383075d9876eb5d64 /actionpack | |
| parent | 63d530c5e68a8cf53603744789f53ccbc7ac1a0e (diff) | |
| download | rails-6f6fe69ea8d2072c49ab7d56b32f19ea27805962.tar.gz rails-6f6fe69ea8d2072c49ab7d56b32f19ea27805962.tar.bz2 rails-6f6fe69ea8d2072c49ab7d56b32f19ea27805962.zip | |
We should call methods with `.method_name` not `::method_name`.
Found several instances.
Follow up on 63d530c5e68a8cf53603744789f53ccbc7ac1a0e
Diffstat (limited to 'actionpack')
| -rw-r--r-- | actionpack/test/controller/http_digest_authentication_test.rb | 9 | ||||
| -rw-r--r-- | actionpack/test/controller/routing_test.rb | 2 |
2 files changed, 6 insertions, 5 deletions
diff --git a/actionpack/test/controller/http_digest_authentication_test.rb b/actionpack/test/controller/http_digest_authentication_test.rb index 76ff784926..560157dc61 100644 --- a/actionpack/test/controller/http_digest_authentication_test.rb +++ b/actionpack/test/controller/http_digest_authentication_test.rb @@ -9,7 +9,7 @@ class HttpDigestAuthenticationTest < ActionController::TestCase before_action :authenticate_with_request, only: :display USERS = { "lifo" => "world", "pretty" => "please", - "dhh" => ::Digest::MD5::hexdigest(["dhh", "SuperSecret", "secret"].join(":")) } + "dhh" => ::Digest::MD5.hexdigest(["dhh", "SuperSecret", "secret"].join(":")) } def index render plain: "Hello Secret" @@ -181,9 +181,10 @@ class HttpDigestAuthenticationTest < ActionController::TestCase end test "authentication request with password stored as ha1 digest hash" do - @request.env["HTTP_AUTHORIZATION"] = encode_credentials(username: "dhh", - password: ::Digest::MD5::hexdigest(["dhh", "SuperSecret", "secret"].join(":")), - password_is_ha1: true) + @request.env["HTTP_AUTHORIZATION"] = encode_credentials( + username: "dhh", + password: ::Digest::MD5.hexdigest(["dhh", "SuperSecret", "secret"].join(":")), + password_is_ha1: true) get :display assert_response :success diff --git a/actionpack/test/controller/routing_test.rb b/actionpack/test/controller/routing_test.rb index ec939e946a..9c0e101f7c 100644 --- a/actionpack/test/controller/routing_test.rb +++ b/actionpack/test/controller/routing_test.rb @@ -676,7 +676,7 @@ class LegacyRouteSetTests < ActiveSupport::TestCase token = "\321\202\320\265\320\272\321\201\321\202".dup # 'text' in Russian token.force_encoding(Encoding::BINARY) - escaped_token = CGI::escape(token) + escaped_token = CGI.escape(token) assert_equal "/page/" + escaped_token, url_for(rs, controller: "content", action: "show_page", id: token) assert_equal({ controller: "content", action: "show_page", id: token }, rs.recognize_path("/page/#{escaped_token}")) |