aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
diff options
context:
space:
mode:
authorSean Griffin <sean@seantheprogrammer.com>2017-07-18 13:42:57 -0400
committerGitHub <noreply@github.com>2017-07-18 13:42:57 -0400
commit36ff7b63ec083924a5b407cf3df7ae90e22183e2 (patch)
tree8cbdbe138f13a0dc7c3666f036fda685c644d262 /actionpack
parent425ba83c28214ca97c5d3600c16ad7a796cd33e6 (diff)
parentf47bac481949a69a519ea7d833e1a8d435332d52 (diff)
downloadrails-36ff7b63ec083924a5b407cf3df7ae90e22183e2.tar.gz
rails-36ff7b63ec083924a5b407cf3df7ae90e22183e2.tar.bz2
rails-36ff7b63ec083924a5b407cf3df7ae90e22183e2.zip
Merge branch 'master' into fix_unscope_where_column_with_or
Diffstat (limited to 'actionpack')
-rw-r--r--actionpack/lib/action_dispatch/request/utils.rb2
-rw-r--r--actionpack/test/dispatch/request_test.rb3
2 files changed, 3 insertions, 2 deletions
diff --git a/actionpack/lib/action_dispatch/request/utils.rb b/actionpack/lib/action_dispatch/request/utils.rb
index 4f79c4c21e..daac68d4b4 100644
--- a/actionpack/lib/action_dispatch/request/utils.rb
+++ b/actionpack/lib/action_dispatch/request/utils.rb
@@ -32,7 +32,7 @@ module ActionDispatch
unless params.valid_encoding?
# Raise Rack::Utils::InvalidParameterError for consistency with Rack.
# ActionDispatch::Request#GET will re-raise as a BadRequest error.
- raise Rack::Utils::InvalidParameterError, "Non UTF-8 value: #{params}"
+ raise Rack::Utils::InvalidParameterError, "Invalid encoding for parameter: #{params.scrub}"
end
end
end
diff --git a/actionpack/test/dispatch/request_test.rb b/actionpack/test/dispatch/request_test.rb
index 899b27b962..61ae99eadc 100644
--- a/actionpack/test/dispatch/request_test.rb
+++ b/actionpack/test/dispatch/request_test.rb
@@ -1024,7 +1024,8 @@ class RequestParameters < BaseRequestTest
request.path_parameters = { foo: "\xBE" }
end
- assert_equal "Invalid path parameters: Non UTF-8 value: \xBE", err.message
+ assert_predicate err.message, :valid_encoding?
+ assert_equal "Invalid path parameters: Invalid encoding for parameter: �", err.message
end
test "parameters not accessible after rack parse error of invalid UTF8 character" do