Remove Route#build as it wasn't used

After @kamipo CR feedback we realized `Route#build` wasn't used. As it
is also private API being able to create Routes both with `#new` and
`#build` was redundant.

2 files changed, 21 insertions, 28 deletions

diff --git a/actionpack/lib/action_dispatch/journey/route.rb b/actionpack/lib/action_dispatch/journey/route.rb
index d497b9d475..4aee7a6f83 100644
--- a/actionpack/lib/action_dispatch/journey/route.rb
+++ b/actionpack/lib/action_dispatch/journey/route.rb
@@ -49,16 +49,10 @@ module ActionDispatch
         end
       end
 
-      def self.build(name, app, path, constraints, required_defaults, defaults)
-        new name: name, app: app, path: path, constraints: constraints,
-            required_defaults: required_defaults, defaults: defaults,
-            request_method_match: verb_matcher(constraints.delete(:request_method))
-      end
-
       ##
       # +path+ is a path constraint.
       # +constraints+ is a hash of constraints to be applied to this route.
-      def initialize(name:, app:, path:, constraints:, required_defaults:, defaults:, request_method_match:, precedence: 0, scope_options: {}, internal: false)
+      def initialize(name:, app: nil, path:, constraints: {}, required_defaults: [], defaults: {}, request_method_match: nil, precedence: 0, scope_options: {}, internal: false)
         @name        = name
         @app         = app
         @path        = path
diff --git a/actionpack/test/journey/route_test.rb b/actionpack/test/journey/route_test.rb
index a8bf4a11e2..8828201e4f 100644
--- a/actionpack/test/journey/route_test.rb
+++ b/actionpack/test/journey/route_test.rb
@@ -9,7 +9,7 @@ module ActionDispatch
         app      = Object.new
         path     = Path::Pattern.from_string "/:controller(/:action(/:id(.:format)))"
         defaults = {}
-        route    = Route.build("name", app, path, {}, [], defaults)
+        route    = Route.new(name: "name", app: app, path: path, defaults: defaults)
 
         assert_equal app, route.app
         assert_equal path, route.path
@@ -17,10 +17,9 @@ module ActionDispatch
       end
 
       def test_route_adds_itself_as_memo
-        app      = Object.new
-        path     = Path::Pattern.from_string "/:controller(/:action(/:id(.:format)))"
-        defaults = {}
-        route    = Route.build("name", app, path, {}, [], defaults)
+        app   = Object.new
+        path  = Path::Pattern.from_string "/:controller(/:action(/:id(.:format)))"
+        route = Route.new(name: "name", app: app, path: path)
 
         route.ast.grep(Nodes::Terminal).each do |node|
           assert_equal route, node.memo
@@ -28,30 +27,30 @@ module ActionDispatch
       end
 
       def test_path_requirements_override_defaults
-        path = Path::Pattern.build(":name", { name: /love/ }, "/", true)
-        defaults  = { name: "tender" }
-        route     = Route.build("name", nil, path, {}, [], defaults)
+        path     = Path::Pattern.build(":name", { name: /love/ }, "/", true)
+        defaults = { name: "tender" }
+        route    = Route.new(name: "name", path: path, defaults: defaults)
         assert_equal(/love/, route.requirements[:name])
       end
 
       def test_ip_address
         path  = Path::Pattern.from_string "/messages/:id(.:format)"
-        route = Route.build("name", nil, path, { ip: "192.168.1.1" }, [],
-                          controller: "foo", action: "bar")
+        route = Route.new(name: "name", path: path, constraints: { ip: "192.168.1.1" },
+                          defaults: { controller: "foo", action: "bar" })
         assert_equal "192.168.1.1", route.ip
       end
 
       def test_default_ip
         path  = Path::Pattern.from_string "/messages/:id(.:format)"
-        route = Route.build("name", nil, path, {}, [],
-                          controller: "foo", action: "bar")
+        route = Route.new(name: "name", path: path,
+                          defaults: { controller: "foo", action: "bar" })
         assert_equal(//, route.ip)
       end
 
       def test_format_with_star
         path  = Path::Pattern.from_string "/:controller/*extra"
-        route = Route.build("name", nil, path, {}, [],
-                          controller: "foo", action: "bar")
+        route = Route.new(name: "name", path: path,
+                          defaults: { controller: "foo", action: "bar" })
         assert_equal "/foo/himom", route.format(
           controller: "foo",
           extra: "himom")
@@ -59,7 +58,8 @@ module ActionDispatch
 
       def test_connects_all_match
         path  = Path::Pattern.from_string "/:controller(/:action(/:id(.:format)))"
-        route = Route.build("name", nil, path, { action: "bar" }, [], controller: "foo")
+        route = Route.new(name: "name", path: path, constraints: { action: "bar" },
+                          defaults: { controller: "foo" })
 
         assert_equal "/foo/bar/10", route.format(
           controller: "foo",
@@ -69,34 +69,33 @@ module ActionDispatch
 
       def test_extras_are_not_included_if_optional
         path  = Path::Pattern.from_string "/page/:id(/:action)"
-        route = Route.build("name", nil, path, {}, [], action: "show")
+        route = Route.new(name: "name", path: path, defaults: { action: "show" })
 
         assert_equal "/page/10", route.format(id: 10)
       end
 
       def test_extras_are_not_included_if_optional_with_parameter
         path  = Path::Pattern.from_string "(/sections/:section)/pages/:id"
-        route = Route.build("name", nil, path, {}, [], action: "show")
+        route = Route.new(name: "name", path: path, defaults: { action: "show" })
 
         assert_equal "/pages/10", route.format(id: 10)
       end
 
       def test_extras_are_not_included_if_optional_parameter_is_nil
         path  = Path::Pattern.from_string "(/sections/:section)/pages/:id"
-        route = Route.build("name", nil, path, {}, [], action: "show")
+        route = Route.new(name: "name", path: path, defaults: { action: "show" })
 
         assert_equal "/pages/10", route.format(id: 10, section: nil)
       end
 
       def test_score
-        constraints = {}
         defaults = { controller: "pages", action: "show" }
 
         path = Path::Pattern.from_string "/page/:id(/:action)(.:format)"
-        specific = Route.build "name", nil, path, constraints, [:controller, :action], defaults
+        specific = Route.new name: "name", path: path, required_defaults: [:controller, :action], defaults: defaults
 
         path = Path::Pattern.from_string "/:controller(/:action(/:id))(.:format)"
-        generic = Route.build "name", nil, path, constraints, [], {}
+        generic = Route.new name: "name", path: path
 
         knowledge = { "id" => true, "controller" => true, "action" => true }