diff options
| author | Xavier Noria <fxn@hashref.com> | 2016-04-21 09:18:35 +0200 |
|---|---|---|
| committer | Xavier Noria <fxn@hashref.com> | 2016-04-21 09:25:38 +0200 |
| commit | 0f8eefa6a581f1f04a1258342419c2896f9062ab (patch) | |
| tree | b0c12d1f883a88140381b6aa3773c8b1255a15da /actionpack | |
| parent | fe9e9f439095a81c5b22c35cd3cbb5cef479b426 (diff) | |
| download | rails-0f8eefa6a581f1f04a1258342419c2896f9062ab.tar.gz rails-0f8eefa6a581f1f04a1258342419c2896f9062ab.tar.bz2 rails-0f8eefa6a581f1f04a1258342419c2896f9062ab.zip | |
restores code comments in String#blank? [ci skip]
When you come here without context, it is important to hightlight that
checking the predicate is worthwhile due to the observation that blank
strings are often empty. So you complicate the code (which has a cost
in terms of readability and aesthetics), but statistically makes sense.
Then, you also need to explain why the second operand is so convoluted.
Otherwise, you wonder why this line is written precisely this way. That
is what code comments are for.
Diffstat (limited to 'actionpack')
0 files changed, 0 insertions, 0 deletions