aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
diff options
context:
space:
mode:
authorKir Shatrov <shatrov@me.com>2017-06-24 10:57:36 -0400
committerKir Shatrov <shatrov@me.com>2017-07-29 14:03:52 +0300
commit0668c22a41e4c88ccb7600fc5b4bfb1a5b76e45d (patch)
tree83ab792d98f40879901860712248559a8a1ebc27 /actionpack
parent904f1a8747958129124d86b44e36c5f0263e0125 (diff)
downloadrails-0668c22a41e4c88ccb7600fc5b4bfb1a5b76e45d.tar.gz
rails-0668c22a41e4c88ccb7600fc5b4bfb1a5b76e45d.tar.bz2
rails-0668c22a41e4c88ccb7600fc5b4bfb1a5b76e45d.zip
Eager load controller and mailer actions
On the first request, ActionController::Base#action_methods computes and memoized the list of available actions [1]. With this PR we move this expensive operation into eager load step to reduce response time of the first request served in production. This also reduces the memory footprint when running on forking server like Unicorn. [1] https://github.com/rails/rails/blob/a3813dce9a0c950a4af7909111fa730a2622b1db/actionpack/lib/abstract_controller/base.rb#L66-L77
Diffstat (limited to 'actionpack')
-rw-r--r--actionpack/lib/action_controller/railtie.rb6
1 files changed, 6 insertions, 0 deletions
diff --git a/actionpack/lib/action_controller/railtie.rb b/actionpack/lib/action_controller/railtie.rb
index 1c1cd58732..0d7a230b17 100644
--- a/actionpack/lib/action_controller/railtie.rb
+++ b/actionpack/lib/action_controller/railtie.rb
@@ -77,5 +77,11 @@ module ActionController
end
end
end
+
+ initializer "action_controller.eager_load_actions" do
+ ActiveSupport.on_load(:after_initialize) do
+ ActionController::Metal.descendants.each(&:action_methods) if config.eager_load
+ end
+ end
end
end