aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
diff options
context:
space:
mode:
authoreileencodes <eileencodes@gmail.com>2017-11-30 12:26:33 -0500
committereileencodes <eileencodes@gmail.com>2017-11-30 12:26:33 -0500
commit0185aae747676e636a52eb079a0a10a6f053fa2c (patch)
tree5c277eb1ef48cf16c9297b63076b2fc7e25c7703 /actionpack
parentcf0a942a40da2065f26a929e1d0f4df25329e768 (diff)
downloadrails-0185aae747676e636a52eb079a0a10a6f053fa2c.tar.gz
rails-0185aae747676e636a52eb079a0a10a6f053fa2c.tar.bz2
rails-0185aae747676e636a52eb079a0a10a6f053fa2c.zip
Add changelog entry for 9d6e28
Since this changes a default setting a changelog entry is important.
Diffstat (limited to 'actionpack')
-rw-r--r--actionpack/CHANGELOG.md12
1 files changed, 12 insertions, 0 deletions
diff --git a/actionpack/CHANGELOG.md b/actionpack/CHANGELOG.md
index c8fb34ed52..d120d15770 100644
--- a/actionpack/CHANGELOG.md
+++ b/actionpack/CHANGELOG.md
@@ -1,3 +1,15 @@
+* Changed the default system test screenshot output from `inline` to `simple`.
+
+ `inline` works well for iTerm2 but not everyone uses iTerm2. Some terminals like
+ Terminal.app ignore the `inline` and output the path to the file since it can't
+ render the image. Other terminals, like those on Ubuntu, cannot handle the image
+ inline, but also don't handle it gracefully and instead of outputting the file
+ path, it dumps binary into the terminal.
+
+ Commit 9d6e28 fixes this by changing the default for screenshot to be `simple`.
+
+ *Eileen M. Uchitelle*
+
* Register most popular audio/video/font mime types supported by modern browsers.
*Guillermo Iguaran*