aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
diff options
context:
space:
mode:
authorArtem Rashev <stillintop@gmail.com>2016-09-19 21:54:23 +0300
committerArtem Rashev <stillintop@gmail.com>2016-11-15 12:50:38 +0300
commitb388ca41d8b26f027a43e96c5ad0950a6bf2f5d7 (patch)
tree2b94cae7715eadb1d74654bbc6df31526aa5b73b /actionpack/test
parent3a558aa2bc8ce3834ee79ff3346bcf5d7debbbd0 (diff)
downloadrails-b388ca41d8b26f027a43e96c5ad0950a6bf2f5d7.tar.gz
rails-b388ca41d8b26f027a43e96c5ad0950a6bf2f5d7.tar.bz2
rails-b388ca41d8b26f027a43e96c5ad0950a6bf2f5d7.zip
Fixed CONTENT_LENGTH header in ActionController::TestRequest
CONENT_LENGTH setted by string length, which is equal to number of characters in string but StringIO.length is byte sequence and when payload contains non-ASCII characters, stream's length will be different. That's why real byte length should be used for CONTENT_LENGTH header. Add unit test for CONTENT_LENGTH header fix It just passes non-ascii symbols as parameters and verifies that "CONTENT_LENGTH" header has content bytes count as value.
Diffstat (limited to 'actionpack/test')
-rw-r--r--actionpack/test/controller/request/test_request_test.rb10
1 files changed, 10 insertions, 0 deletions
diff --git a/actionpack/test/controller/request/test_request_test.rb b/actionpack/test/controller/request/test_request_test.rb
index fa049fbc9f..da6fa1388b 100644
--- a/actionpack/test/controller/request/test_request_test.rb
+++ b/actionpack/test/controller/request/test_request_test.rb
@@ -11,6 +11,16 @@ class ActionController::TestRequestTest < ActionController::TestCase
assert_equal nil, ActionController::TestSession::DEFAULT_OPTIONS[:myparam]
end
+ def test_content_length_has_bytes_count_value
+ non_ascii_parameters = { data: { content: "Latin + Кириллица" } }
+ @request.set_header "REQUEST_METHOD", "POST"
+ @request.set_header "CONTENT_TYPE", "application/json"
+ @request.assign_parameters(@routes, "test", "create", non_ascii_parameters,
+ "/test", [:data, :controller, :action])
+ assert_equal(@request.get_header("CONTENT_LENGTH"),
+ StringIO.new(non_ascii_parameters.to_json).length.to_s)
+ end
+
ActionDispatch::Session::AbstractStore::DEFAULT_OPTIONS.each_key do |option|
test "rack default session options #{option} exists in session options and is default" do
assert_equal(ActionDispatch::Session::AbstractStore::DEFAULT_OPTIONS[option],