diff options
author | Jonathan del Strother <jon.delStrother@bestbefore.tv> | 2008-09-02 17:33:52 +0100 |
---|---|---|
committer | Jeremy Kemper <jeremy@bitsweat.net> | 2008-09-02 22:57:40 +0200 |
commit | 6cfb70023a7b102debaa7f1505b173556a285ae7 (patch) | |
tree | e0ad6b193959f6f24ee50c5d6a2717ec25ef65ac /actionpack/test | |
parent | 6f932b4790371e548c0df9033da96b2cf8f51dcc (diff) | |
download | rails-6cfb70023a7b102debaa7f1505b173556a285ae7.tar.gz rails-6cfb70023a7b102debaa7f1505b173556a285ae7.tar.bz2 rails-6cfb70023a7b102debaa7f1505b173556a285ae7.zip |
Don't set Content-Length on 304 responses
Commit 8aad8c claimed to do this, but it checks for the 304 status too early, before handle_conditional_get! has overridden it.
[#958 state:resolved]
Signed-off-by: Jonathan del Strother <jon.delStrother@bestbefore.tv>
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Diffstat (limited to 'actionpack/test')
-rw-r--r-- | actionpack/test/controller/render_test.rb | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/actionpack/test/controller/render_test.rb b/actionpack/test/controller/render_test.rb index c4a2bf3db3..af7b5dde62 100644 --- a/actionpack/test/controller/render_test.rb +++ b/actionpack/test/controller/render_test.rb @@ -1321,6 +1321,12 @@ class EtagRenderTest < Test::Unit::TestCase assert @response.body.empty? end + def test_render_against_etag_request_should_have_no_content_length_when_match + @request.if_none_match = etag_for("hello david") + get :render_hello_world_from_variable + assert !@response.headers.has_key?("Content-Length") + end + def test_render_against_etag_request_should_200_when_no_match @request.if_none_match = etag_for("hello somewhere else") get :render_hello_world_from_variable |