diff options
| author | Aleksey Magusev <lexmag@gmail.com> | 2012-09-03 00:40:49 +0400 |
|---|---|---|
| committer | Aleksey Magusev <lexmag@gmail.com> | 2012-09-05 02:49:10 +0400 |
| commit | 69723138ad67a3c0b708b907f2831531cf87e55b (patch) | |
| tree | 09760863cc24d5223728bfb4aef5c13016ea0b98 /actionpack/test | |
| parent | ebc50c505d3c49b0fac7eccf85da6df751d4023c (diff) | |
| download | rails-69723138ad67a3c0b708b907f2831531cf87e55b.tar.gz rails-69723138ad67a3c0b708b907f2831531cf87e55b.tar.bz2 rails-69723138ad67a3c0b708b907f2831531cf87e55b.zip | |
Refactor `Mime::Type`
`parse` method performance improvements - ~27-33%:
accept = "image/gif, image/x-xbitmap, image/jpeg, image/pjpeg, application/x-shockwave-flash, application/vnd.ms-excel, application/vnd.ms-powerpoint, application/msword, , pronto/1.00.00, sslvpn/1.00.00.00, */*"
Benchmark.measure{ 1_000_0.times { Mime::Type.parse(accept) }}
old: 1.430000 0.000000 1.430000 ( 1.440977)
new: 0.920000 0.000000 0.920000 ( 0.921813)
Diffstat (limited to 'actionpack/test')
| -rw-r--r-- | actionpack/test/dispatch/mime_type_test.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/actionpack/test/dispatch/mime_type_test.rb b/actionpack/test/dispatch/mime_type_test.rb index ed012093a7..3e83f3d4fa 100644 --- a/actionpack/test/dispatch/mime_type_test.rb +++ b/actionpack/test/dispatch/mime_type_test.rb @@ -92,7 +92,7 @@ class MimeTypeTest < ActiveSupport::TestCase # (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322; InfoPath.1) test "parse other broken acceptlines" do accept = "image/gif, image/x-xbitmap, image/jpeg, image/pjpeg, application/x-shockwave-flash, application/vnd.ms-excel, application/vnd.ms-powerpoint, application/msword, , pronto/1.00.00, sslvpn/1.00.00.00, */*" - expect = ['image/gif', 'image/x-xbitmap', 'image/jpeg','image/pjpeg', 'application/x-shockwave-flash', 'application/vnd.ms-excel', 'application/vnd.ms-powerpoint', 'application/msword', 'pronto/1.00.00', 'sslvpn/1.00.00.00', Mime::ALL ] + expect = ['image/gif', 'image/x-xbitmap', 'image/jpeg','image/pjpeg', 'application/x-shockwave-flash', 'application/vnd.ms-excel', 'application/vnd.ms-powerpoint', 'application/msword', 'pronto/1.00.00', 'sslvpn/1.00.00.00', Mime::ALL] assert_equal expect, Mime::Type.parse(accept).collect { |c| c.to_s } end |