aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/routing
diff options
context:
space:
mode:
authorEarl J St Sauver <estsauver@gmail.com>2014-04-27 16:41:25 -0700
committerArthur Neves <arthurnn@gmail.com>2014-07-18 13:23:45 -0400
commit9ff18e4626ceb3e50b81b2966d304d02160b619e (patch)
tree25e301e00aeef7cab77d2c7738c4b5c30f1a40a5 /actionpack/test/routing
parent843b8c0b8c8cccd8d1432060dfc79a8edcc4ed2c (diff)
downloadrails-9ff18e4626ceb3e50b81b2966d304d02160b619e.tar.gz
rails-9ff18e4626ceb3e50b81b2966d304d02160b619e.tar.bz2
rails-9ff18e4626ceb3e50b81b2966d304d02160b619e.zip
LOCALHOST definition should match any 127.0.0.0/8 address
The entire 127.0.0.0/8 range is assigned to the loopback address, not only 127.0.0.0/24. This patch allows ActionDispatch::Request::LOCALHOST to match any IPv4 127.0.0.0/8 loopback address. The only place that the #local? method was previously under test was in the show_expectations_test.rb file. I don't particularly like that that's implicitly where this code is under test, and I feel like I should move some of that testing code into the test/dispatch/request_test.rb file, but I wanted some feedback first. Credit goes to @sriedel for discovering the issue and adding the patch.
Diffstat (limited to 'actionpack/test/routing')
0 files changed, 0 insertions, 0 deletions