diff options
| author | Chris Carter <chris.carter@unboxedconsulting.com> | 2016-09-20 10:42:26 +0100 |
|---|---|---|
| committer | Chris Carter <chris.carter@unboxedconsulting.com> | 2016-10-03 09:52:14 +0100 |
| commit | 0b32e2dff353ceb9bc463787c5897ecae7302ab7 (patch) | |
| tree | b549472a55b336e05bbad52b98630f360f53f63f /actionpack/test/journey | |
| parent | 2d6c14bca25c5629e431a802c3053bad1e378fcc (diff) | |
| download | rails-0b32e2dff353ceb9bc463787c5897ecae7302ab7.tar.gz rails-0b32e2dff353ceb9bc463787c5897ecae7302ab7.tar.bz2 rails-0b32e2dff353ceb9bc463787c5897ecae7302ab7.zip | |
Show an "unmatched constraints" error for mismatching and present params
Currently a misleading "missing required keys" error is thrown when a param
fails to match the constraints of a particular route. This commit ensures that
these params are recognised as unmatching rather than missing.
Note: this means that a different error message will be provided between
optimized and non-optimized path helpers, due to the fact that the former does
not check constraints when matching routes.
Fixes #26470.
Diffstat (limited to 'actionpack/test/journey')
| -rw-r--r-- | actionpack/test/journey/router_test.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/actionpack/test/journey/router_test.rb b/actionpack/test/journey/router_test.rb index 2b99637f56..7b5916eb72 100644 --- a/actionpack/test/journey/router_test.rb +++ b/actionpack/test/journey/router_test.rb @@ -297,7 +297,7 @@ module ActionDispatch } request_parameters = primarty_parameters.merge(redirection_parameters).merge(missing_parameters) - message = "No route matches #{Hash[request_parameters.sort_by { |k,v|k.to_s }].inspect} missing required keys: #{[missing_key.to_sym].inspect}" + message = "No route matches #{Hash[request_parameters.sort_by { |k,v|k.to_s }].inspect}, missing required keys: #{[missing_key.to_sym].inspect}" error = assert_raises(ActionController::UrlGenerationError) do @formatter.generate( |