aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/journey/router_test.rb
diff options
context:
space:
mode:
authorGuo Xiang Tan <tgx_world@hotmail.com>2014-07-03 21:32:14 -0700
committerGuo Xiang Tan <tgx_world@hotmail.com>2014-08-21 16:35:39 +0800
commitd3eb92d95a694905a80668dcde1fb49e2d08f388 (patch)
tree2c96c2cecafb1e4f36def16b989104d7668f0aed /actionpack/test/journey/router_test.rb
parentd3b0bb28ba4cf8c7043546349f932ef2dd98ff04 (diff)
downloadrails-d3eb92d95a694905a80668dcde1fb49e2d08f388.tar.gz
rails-d3eb92d95a694905a80668dcde1fb49e2d08f388.tar.bz2
rails-d3eb92d95a694905a80668dcde1fb49e2d08f388.zip
Avoid duplicating routes for HEAD requests.
Follow up to rails#15321 Instead of duplicating the routes, we will first match the HEAD request to HEAD routes. If no match is found, we will then map the HEAD request to GET routes.
Diffstat (limited to 'actionpack/test/journey/router_test.rb')
-rw-r--r--actionpack/test/journey/router_test.rb21
1 files changed, 20 insertions, 1 deletions
diff --git a/actionpack/test/journey/router_test.rb b/actionpack/test/journey/router_test.rb
index 2e7e8e1bea..8fc965adf4 100644
--- a/actionpack/test/journey/router_test.rb
+++ b/actionpack/test/journey/router_test.rb
@@ -503,6 +503,25 @@ module ActionDispatch
assert called
end
+ def test_recognize_head_route
+ path = Path::Pattern.from_string "/books(/:action(.:format))"
+ app = Object.new
+ conditions = { request_method: 'HEAD' }
+ @router.routes.add_route(app, path, conditions, {})
+
+ env = rails_env(
+ 'PATH_INFO' => '/books/list.rss',
+ 'REQUEST_METHOD' => 'HEAD'
+ )
+
+ called = false
+ @router.recognize(env) do |r, params|
+ called = true
+ end
+
+ assert called
+ end
+
def test_recognize_head_request_as_get_route
path = Path::Pattern.from_string "/books(/:action(.:format))"
app = Object.new
@@ -561,7 +580,7 @@ module ActionDispatch
end
def rails_env env, klass = ActionDispatch::Request
- klass.new env
+ klass.new(rack_env(env))
end
def rack_env env