diff options
| author | John Hawthorn <john@hawthorn.email> | 2019-05-07 13:16:57 -0700 |
|---|---|---|
| committer | John Hawthorn <john@hawthorn.email> | 2019-05-08 13:30:41 -0700 |
| commit | 6f549ce53f3398403d4c2a47f9ecba910be256dd (patch) | |
| tree | 866b93d0aa56cf3fcca33ecf92b215f1ddc1393b /actionpack/test/dispatch/test_response_test.rb | |
| parent | 52125dc0f8669d8dd497427c7b177d5d04106e0c (diff) | |
| download | rails-6f549ce53f3398403d4c2a47f9ecba910be256dd.tar.gz rails-6f549ce53f3398403d4c2a47f9ecba910be256dd.tar.bz2 rails-6f549ce53f3398403d4c2a47f9ecba910be256dd.zip | |
Only build middleware proxy when instrumentating
The instrumentation proxy adds three stack frames per-middleware, even
when nothing is listening.
This commit, when the middleware stack is built, only adds
instrumentation when the `process_middleware.action_dispatch` event has
already been subscribed to.
The advantage to this is that we don't have any extra stack frames in
apps which don't need middleware instrumentation.
The disadvantage is that the subscriptions need to be in place when the
middleware stack is built (during app boot). I think this is likely okay
because temporary AS::Notifications subscriptions are strongly
discouraged.
Diffstat (limited to 'actionpack/test/dispatch/test_response_test.rb')
0 files changed, 0 insertions, 0 deletions