aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/dispatch/system_testing/driver_test.rb
diff options
context:
space:
mode:
authoreileencodes <eileencodes@gmail.com>2017-07-08 11:08:03 -0400
committereileencodes <eileencodes@gmail.com>2017-07-08 11:13:28 -0400
commit91d22b783275474464a03f6487f5c28b5dc803b3 (patch)
tree797cf240a7532af1c439c903db1e47e2d855e230 /actionpack/test/dispatch/system_testing/driver_test.rb
parenta136c291ed29953787e8218137c01eadf6da63a8 (diff)
downloadrails-91d22b783275474464a03f6487f5c28b5dc803b3.tar.gz
rails-91d22b783275474464a03f6487f5c28b5dc803b3.tar.bz2
rails-91d22b783275474464a03f6487f5c28b5dc803b3.zip
Don't call register on custom drivers
It's possible for developers toadd a custom driver and then call it using `driven_by`. Because we were only skipping `register` for `:rack_test` that meant any custom driver would attempt to be registered as well. The three listed here are special because Rails registers them with special options. If you're registering your own custom driver then you don't want to separately register that driver. Fixes #29688
Diffstat (limited to 'actionpack/test/dispatch/system_testing/driver_test.rb')
-rw-r--r--actionpack/test/dispatch/system_testing/driver_test.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/actionpack/test/dispatch/system_testing/driver_test.rb b/actionpack/test/dispatch/system_testing/driver_test.rb
index 4a1b971da5..34d27671bb 100644
--- a/actionpack/test/dispatch/system_testing/driver_test.rb
+++ b/actionpack/test/dispatch/system_testing/driver_test.rb
@@ -29,7 +29,7 @@ class DriverTest < ActiveSupport::TestCase
assert_equal ({ skip_image_loading: true }), driver.instance_variable_get(:@options)
end
- test "rack_test? returns false if driver is poltergeist" do
- assert_not ActionDispatch::SystemTesting::Driver.new(:poltergeist).send(:rack_test?)
+ test "registerable? returns false if driver is rack_test" do
+ assert_not ActionDispatch::SystemTesting::Driver.new(:rack_test).send(:registerable?)
end
end