Clear url helper methods when routes are reloaded

Remove all the old url helper methods when clear! is called on the
route set because it's possible that some routes have been removed.

1 files changed, 86 insertions, 0 deletions

diff --git a/actionpack/test/dispatch/routing/route_set_test.rb b/actionpack/test/dispatch/routing/route_set_test.rb
new file mode 100644
index 0000000000..d57b1a5637
--- /dev/null
+++ b/actionpack/test/dispatch/routing/route_set_test.rb
@@ -0,0 +1,86 @@
+require 'abstract_unit'
+
+module ActionDispatch
+  module Routing
+    class RouteSetTest < ActiveSupport::TestCase
+      class SimpleApp
+        def initialize(response)
+          @response = response
+        end
+
+        def call(env)
+          [ 200, { 'Content-Type' => 'text/plain' }, [response] ]
+        end
+      end
+
+      setup do
+        @set = RouteSet.new
+      end
+
+      test "url helpers are added when route is added" do
+        draw do
+          get 'foo', to: SimpleApp.new('foo#index')
+        end
+
+        assert_equal '/foo', url_helpers.foo_path
+        assert_raises NoMethodError do
+          assert_equal '/bar', url_helpers.bar_path
+        end
+
+        draw do
+          get 'foo', to: SimpleApp.new('foo#index')
+          get 'bar', to: SimpleApp.new('bar#index')
+        end
+
+        assert_equal '/foo', url_helpers.foo_path
+        assert_equal '/bar', url_helpers.bar_path
+      end
+
+      test "url helpers are updated when route is updated" do
+        draw do
+          get 'bar', to: SimpleApp.new('bar#index'), as: :bar
+        end
+
+        assert_equal '/bar', url_helpers.bar_path
+
+        draw do
+          get 'baz', to: SimpleApp.new('baz#index'), as: :bar
+        end
+
+        assert_equal '/baz', url_helpers.bar_path
+      end
+
+      test "url helpers are removed when route is removed" do
+        draw do
+          get 'foo', to: SimpleApp.new('foo#index')
+          get 'bar', to: SimpleApp.new('bar#index')
+        end
+
+        assert_equal '/foo', url_helpers.foo_path
+        assert_equal '/bar', url_helpers.bar_path
+
+        draw do
+          get 'foo', to: SimpleApp.new('foo#index')
+        end
+
+        assert_equal '/foo', url_helpers.foo_path
+        assert_raises NoMethodError do
+          assert_equal '/bar', url_helpers.bar_path
+        end
+      end
+
+      private
+        def clear!
+          @set.clear!
+        end
+
+        def draw(&block)
+          @set.draw(&block)
+        end
+
+        def url_helpers
+          @set.url_helpers
+        end
+    end
+  end
+end