diff options
| author | Genadi Samokovarov <gsamokovarov@gmail.com> | 2015-03-01 13:28:25 +0200 |
|---|---|---|
| committer | Genadi Samokovarov <gsamokovarov@gmail.com> | 2015-03-01 16:31:20 +0200 |
| commit | 707a433870e9e06af688f85a4aedc64a90791a64 (patch) | |
| tree | ca3170c3cc4a61ae971a5fd920055d395d7c3c21 /actionpack/test/dispatch/response_test.rb | |
| parent | 293bd95c3e77275193130bc14c986348aae8b0e2 (diff) | |
| download | rails-707a433870e9e06af688f85a4aedc64a90791a64.tar.gz rails-707a433870e9e06af688f85a4aedc64a90791a64.tar.bz2 rails-707a433870e9e06af688f85a4aedc64a90791a64.zip | |
Work around for upstream Ruby bug #10685
In f6e293ec54f02f83cdb37502bea117f66f87bcae we avoided a segfault in the
tests, however I think we should try to avoid the crash, as it may
happen in user code as well.
Here is what I distiled the bug down to:
```ruby
# Rails case - works on 2.0, 2.1; crashes on 2.2
require 'action_dispatch'
ActionDispatch::Response.new(200, "Content-Type" => "text/xml")
# General case - works on 2.0, 2.1; crashes on 2.2
def foo(optional = {}, default_argument: nil)
end
foo('quux' => 'bar')
```
Diffstat (limited to 'actionpack/test/dispatch/response_test.rb')
| -rw-r--r-- | actionpack/test/dispatch/response_test.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/actionpack/test/dispatch/response_test.rb b/actionpack/test/dispatch/response_test.rb index f4c0b421d6..c61423dce4 100644 --- a/actionpack/test/dispatch/response_test.rb +++ b/actionpack/test/dispatch/response_test.rb @@ -172,7 +172,7 @@ class ResponseTest < ActiveSupport::TestCase original = ActionDispatch::Response.default_charset begin ActionDispatch::Response.default_charset = 'utf-16' - resp = ActionDispatch::Response.new(200, { "Content-Type" => "text/xml" }, default_headers: nil) + resp = ActionDispatch::Response.new(200, { "Content-Type" => "text/xml" }) assert_equal('utf-16', resp.charset) ensure ActionDispatch::Response.default_charset = original |