applies new string literal convention in actionpack/test

The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.

1 files changed, 99 insertions, 99 deletions

diff --git a/actionpack/test/dispatch/response_test.rb b/actionpack/test/dispatch/response_test.rb
index 9eed796d3c..24a17ca740 100644
--- a/actionpack/test/dispatch/response_test.rb
+++ b/actionpack/test/dispatch/response_test.rb
@@ -1,6 +1,6 @@
-require 'abstract_unit'
-require 'timeout'
-require 'rack/content_length'
+require "abstract_unit"
+require "timeout"
+require "rack/content_length"
 
 class ResponseTest < ActiveSupport::TestCase
   def setup
@@ -40,8 +40,8 @@ class ResponseTest < ActiveSupport::TestCase
   def test_each_isnt_called_if_str_body_is_written
     # Controller writes and reads response body
     each_counter = 0
-    @response.body = Object.new.tap {|o| o.singleton_class.send(:define_method, :each) { |&block| each_counter += 1; block.call 'foo' } }
-    @response['X-Foo'] = @response.body
+    @response.body = Object.new.tap {|o| o.singleton_class.send(:define_method, :each) { |&block| each_counter += 1; block.call "foo" } }
+    @response["X-Foo"] = @response.body
 
     assert_equal 1, each_counter, "#each was not called once"
 
@@ -49,7 +49,7 @@ class ResponseTest < ActiveSupport::TestCase
     status, headers, body = @response.to_a
 
     assert_equal 200, status
-    assert_equal "foo", headers['X-Foo']
+    assert_equal "foo", headers["X-Foo"]
     assert_equal "foo", body.each.to_a.join
 
     # Show that #each was not called twice
@@ -60,14 +60,14 @@ class ResponseTest < ActiveSupport::TestCase
     @response.body
 
     # set header after the action reads back @response.body
-    @response['x-header'] = "Best of all possible worlds."
+    @response["x-header"] = "Best of all possible worlds."
 
     # the response can be built.
     status, headers, body = @response.to_a
     assert_equal 200, status
     assert_equal "", body.body
 
-    assert_equal "Best of all possible worlds.", headers['x-header']
+    assert_equal "Best of all possible worlds.", headers["x-header"]
   end
 
   def test_read_body_during_action
@@ -99,15 +99,15 @@ class ResponseTest < ActiveSupport::TestCase
   end
 
   def test_response_charset_writer
-    @response.charset = 'utf-16'
-    assert_equal 'utf-16', @response.charset
+    @response.charset = "utf-16"
+    assert_equal "utf-16", @response.charset
     @response.charset = nil
-    assert_equal 'utf-8', @response.charset
+    assert_equal "utf-8", @response.charset
   end
 
   def test_setting_content_type_header_impacts_content_type_method
-    @response.headers['Content-Type'] = "application/aaron"
-    assert_equal 'application/aaron', @response.content_type
+    @response.headers["Content-Type"] = "application/aaron"
+    assert_equal "application/aaron", @response.content_type
   end
 
   test "simple output" do
@@ -125,14 +125,14 @@ class ResponseTest < ActiveSupport::TestCase
   end
 
   test "status handled properly in initialize" do
-    assert_equal 200, ActionDispatch::Response.new('200 OK').status
+    assert_equal 200, ActionDispatch::Response.new("200 OK").status
   end
 
   def test_only_set_charset_still_defaults_to_text_html
     response = ActionDispatch::Response.new
     response.charset = "utf-16"
     _,headers,_ = response.to_a
-    assert_equal "text/html; charset=utf-16", headers['Content-Type']
+    assert_equal "text/html; charset=utf-16", headers["Content-Type"]
   end
 
   test "utf8 output" do
@@ -184,7 +184,7 @@ class ResponseTest < ActiveSupport::TestCase
   test "does not include Status header" do
     @response.status = "200 OK"
     _, headers, _ = @response.to_a
-    assert !headers.has_key?('Status')
+    assert !headers.has_key?("Status")
   end
 
   test "response code" do
@@ -245,8 +245,8 @@ class ResponseTest < ActiveSupport::TestCase
   test "read ETag and Cache-Control" do
     resp = ActionDispatch::Response.new.tap { |response|
       response.cache_control[:public] = true
-      response.etag = '123'
-      response.body = 'Hello'
+      response.etag = "123"
+      response.body = "Hello"
     }
     resp.to_a
 
@@ -256,15 +256,15 @@ class ResponseTest < ActiveSupport::TestCase
     assert_equal('W/"202cb962ac59075b964b07152d234b70"', resp.etag)
     assert_equal({:public => true}, resp.cache_control)
 
-    assert_equal('public', resp.headers['Cache-Control'])
-    assert_equal('W/"202cb962ac59075b964b07152d234b70"', resp.headers['ETag'])
+    assert_equal("public", resp.headers["Cache-Control"])
+    assert_equal('W/"202cb962ac59075b964b07152d234b70"', resp.headers["ETag"])
   end
 
   test "read strong ETag" do
     resp = ActionDispatch::Response.new.tap { |response|
       response.cache_control[:public] = true
-      response.strong_etag = '123'
-      response.body = 'Hello'
+      response.strong_etag = "123"
+      response.body = "Hello"
     }
     resp.to_a
 
@@ -276,23 +276,23 @@ class ResponseTest < ActiveSupport::TestCase
 
   test "read charset and content type" do
     resp = ActionDispatch::Response.new.tap { |response|
-      response.charset = 'utf-16'
+      response.charset = "utf-16"
       response.content_type = Mime[:xml]
-      response.body = 'Hello'
+      response.body = "Hello"
     }
     resp.to_a
 
-    assert_equal('utf-16', resp.charset)
+    assert_equal("utf-16", resp.charset)
     assert_equal(Mime[:xml], resp.content_type)
 
-    assert_equal('application/xml; charset=utf-16', resp.headers['Content-Type'])
+    assert_equal("application/xml; charset=utf-16", resp.headers["Content-Type"])
   end
 
   test "read content type with default charset utf-8" do
     original = ActionDispatch::Response.default_charset
     begin
       resp = ActionDispatch::Response.new(200, { "Content-Type" => "text/xml" })
-      assert_equal('utf-8', resp.charset)
+      assert_equal("utf-8", resp.charset)
     ensure
       ActionDispatch::Response.default_charset = original
     end
@@ -301,9 +301,9 @@ class ResponseTest < ActiveSupport::TestCase
   test "read content type with charset utf-16" do
     original = ActionDispatch::Response.default_charset
     begin
-      ActionDispatch::Response.default_charset = 'utf-16'
+      ActionDispatch::Response.default_charset = "utf-16"
       resp = ActionDispatch::Response.new(200, { "Content-Type" => "text/xml" })
-      assert_equal('utf-16', resp.charset)
+      assert_equal("utf-16", resp.charset)
     ensure
       ActionDispatch::Response.default_charset = original
     end
@@ -313,18 +313,18 @@ class ResponseTest < ActiveSupport::TestCase
     original_default_headers = ActionDispatch::Response.default_headers
     begin
       ActionDispatch::Response.default_headers = {
-        'X-Frame-Options' => 'DENY',
-        'X-Content-Type-Options' => 'nosniff',
-        'X-XSS-Protection' => '1;'
+        "X-Frame-Options" => "DENY",
+        "X-Content-Type-Options" => "nosniff",
+        "X-XSS-Protection" => "1;"
       }
       resp = ActionDispatch::Response.create.tap { |response|
-        response.body = 'Hello'
+        response.body = "Hello"
       }
       resp.to_a
 
-      assert_equal('DENY', resp.headers['X-Frame-Options'])
-      assert_equal('nosniff', resp.headers['X-Content-Type-Options'])
-      assert_equal('1;', resp.headers['X-XSS-Protection'])
+      assert_equal("DENY", resp.headers["X-Frame-Options"])
+      assert_equal("nosniff", resp.headers["X-Content-Type-Options"])
+      assert_equal("1;", resp.headers["X-XSS-Protection"])
     ensure
       ActionDispatch::Response.default_headers = original_default_headers
     end
@@ -334,14 +334,14 @@ class ResponseTest < ActiveSupport::TestCase
     original_default_headers = ActionDispatch::Response.default_headers
     begin
       ActionDispatch::Response.default_headers = {
-        'X-XX-XXXX' => 'Here is my phone number'
+        "X-XX-XXXX" => "Here is my phone number"
       }
       resp = ActionDispatch::Response.create.tap { |response|
-        response.body = 'Hello'
+        response.body = "Hello"
       }
       resp.to_a
 
-      assert_equal('Here is my phone number', resp.headers['X-XX-XXXX'])
+      assert_equal("Here is my phone number", resp.headers["X-XX-XXXX"])
     ensure
       ActionDispatch::Response.default_headers = original_default_headers
     end
@@ -353,13 +353,13 @@ class ResponseTest < ActiveSupport::TestCase
   end
 
   test "can be explicitly destructured into status, headers and an enumerable body" do
-    response = ActionDispatch::Response.new(404, { 'Content-Type' => 'text/plain' }, ['Not Found'])
+    response = ActionDispatch::Response.new(404, { "Content-Type" => "text/plain" }, ["Not Found"])
     response.request = ActionDispatch::Request.empty
     status, headers, body = *response
 
     assert_equal 404, status
-    assert_equal({ 'Content-Type' => 'text/plain' }, headers)
-    assert_equal ['Not Found'], body.each.to_a
+    assert_equal({ "Content-Type" => "text/plain" }, headers)
+    assert_equal ["Not Found"], body.each.to_a
   end
 
   test "[response.to_a].flatten does not recurse infinitely" do
@@ -372,74 +372,74 @@ class ResponseTest < ActiveSupport::TestCase
   end
 
   test "compatibility with Rack::ContentLength" do
-    @response.body = 'Hello'
+    @response.body = "Hello"
     app = lambda { |env| @response.to_a }
     env = Rack::MockRequest.env_for("/")
 
     status, headers, body = app.call(env)
-    assert_nil headers['Content-Length']
+    assert_nil headers["Content-Length"]
 
     status, headers, body = Rack::ContentLength.new(app).call(env)
-    assert_equal '5', headers['Content-Length']
+    assert_equal "5", headers["Content-Length"]
   end
 end
 
 class ResponseHeadersTest < ActiveSupport::TestCase
   def setup
     @response = ActionDispatch::Response.create
-    @response.set_header 'Foo', '1'
+    @response.set_header "Foo", "1"
   end
 
-  test 'has_header?' do
-    assert @response.has_header? 'Foo'
-    assert_not @response.has_header? 'foo'
+  test "has_header?" do
+    assert @response.has_header? "Foo"
+    assert_not @response.has_header? "foo"
     assert_not @response.has_header? nil
   end
 
-  test 'get_header' do
-    assert_equal '1', @response.get_header('Foo')
-    assert_nil @response.get_header('foo')
+  test "get_header" do
+    assert_equal "1", @response.get_header("Foo")
+    assert_nil @response.get_header("foo")
     assert_nil @response.get_header(nil)
   end
 
-  test 'set_header' do
-    assert_equal '2', @response.set_header('Foo', '2')
-    assert @response.has_header?('Foo')
-    assert_equal '2', @response.get_header('Foo')
+  test "set_header" do
+    assert_equal "2", @response.set_header("Foo", "2")
+    assert @response.has_header?("Foo")
+    assert_equal "2", @response.get_header("Foo")
 
-    assert_nil @response.set_header('Foo', nil)
-    assert @response.has_header?('Foo')
-    assert_nil @response.get_header('Foo')
+    assert_nil @response.set_header("Foo", nil)
+    assert @response.has_header?("Foo")
+    assert_nil @response.get_header("Foo")
   end
 
-  test 'delete_header' do
+  test "delete_header" do
     assert_nil @response.delete_header(nil)
 
-    assert_nil @response.delete_header('foo')
-    assert @response.has_header?('Foo')
+    assert_nil @response.delete_header("foo")
+    assert @response.has_header?("Foo")
 
-    assert_equal '1', @response.delete_header('Foo')
-    assert_not @response.has_header?('Foo')
+    assert_equal "1", @response.delete_header("Foo")
+    assert_not @response.has_header?("Foo")
   end
 
-  test 'add_header' do
+  test "add_header" do
     # Add a value to an existing header
-    assert_equal '1,2', @response.add_header('Foo', '2')
-    assert_equal '1,2', @response.get_header('Foo')
+    assert_equal "1,2", @response.add_header("Foo", "2")
+    assert_equal "1,2", @response.get_header("Foo")
 
     # Add nil to an existing header
-    assert_equal '1,2', @response.add_header('Foo', nil)
-    assert_equal '1,2', @response.get_header('Foo')
+    assert_equal "1,2", @response.add_header("Foo", nil)
+    assert_equal "1,2", @response.get_header("Foo")
 
     # Add nil to a nonexistent header
-    assert_nil @response.add_header('Bar', nil)
-    assert_not @response.has_header?('Bar')
-    assert_nil @response.get_header('Bar')
+    assert_nil @response.add_header("Bar", nil)
+    assert_not @response.has_header?("Bar")
+    assert_nil @response.get_header("Bar")
 
     # Add a value to a nonexistent header
-    assert_equal '1', @response.add_header('Bar', '1')
-    assert @response.has_header?('Bar')
-    assert_equal '1', @response.get_header('Bar')
+    assert_equal "1", @response.add_header("Bar", "1")
+    assert @response.has_header?("Bar")
+    assert_equal "1", @response.get_header("Bar")
   end
 end
 
@@ -448,17 +448,17 @@ class ResponseIntegrationTest < ActionDispatch::IntegrationTest
     @app = lambda { |env|
       ActionDispatch::Response.new.tap { |resp|
         resp.cache_control[:public] = true
-        resp.etag = '123'
-        resp.body = 'Hello'
+        resp.etag = "123"
+        resp.body = "Hello"
         resp.request = ActionDispatch::Request.empty
       }.to_a
     }
 
-    get '/'
+    get "/"
     assert_response :success
 
-    assert_equal('public', @response.headers['Cache-Control'])
-    assert_equal('W/"202cb962ac59075b964b07152d234b70"', @response.headers['ETag'])
+    assert_equal("public", @response.headers["Cache-Control"])
+    assert_equal('W/"202cb962ac59075b964b07152d234b70"', @response.headers["ETag"])
 
     assert_equal('W/"202cb962ac59075b964b07152d234b70"', @response.etag)
     assert_equal({:public => true}, @response.cache_control)
@@ -467,15 +467,15 @@ class ResponseIntegrationTest < ActionDispatch::IntegrationTest
   test "response cache control from rackish app" do
     @app = lambda { |env|
       [200,
-        {'ETag' => 'W/"202cb962ac59075b964b07152d234b70"',
-          'Cache-Control' => 'public'}, ['Hello']]
+        {"ETag" => 'W/"202cb962ac59075b964b07152d234b70"',
+          "Cache-Control" => "public"}, ["Hello"]]
     }
 
-    get '/'
+    get "/"
     assert_response :success
 
-    assert_equal('public', @response.headers['Cache-Control'])
-    assert_equal('W/"202cb962ac59075b964b07152d234b70"', @response.headers['ETag'])
+    assert_equal("public", @response.headers["Cache-Control"])
+    assert_equal('W/"202cb962ac59075b964b07152d234b70"', @response.headers["ETag"])
 
     assert_equal('W/"202cb962ac59075b964b07152d234b70"', @response.etag)
     assert_equal({:public => true}, @response.cache_control)
@@ -484,51 +484,51 @@ class ResponseIntegrationTest < ActionDispatch::IntegrationTest
   test "response charset and content type from railsish app" do
     @app = lambda { |env|
       ActionDispatch::Response.new.tap { |resp|
-        resp.charset = 'utf-16'
+        resp.charset = "utf-16"
         resp.content_type = Mime[:xml]
-        resp.body = 'Hello'
+        resp.body = "Hello"
         resp.request = ActionDispatch::Request.empty
       }.to_a
     }
 
-    get '/'
+    get "/"
     assert_response :success
 
-    assert_equal('utf-16', @response.charset)
+    assert_equal("utf-16", @response.charset)
     assert_equal(Mime[:xml], @response.content_type)
 
-    assert_equal('application/xml; charset=utf-16', @response.headers['Content-Type'])
+    assert_equal("application/xml; charset=utf-16", @response.headers["Content-Type"])
   end
 
   test "response charset and content type from rackish app" do
     @app = lambda { |env|
       [200,
-        {'Content-Type' => 'application/xml; charset=utf-16'},
-        ['Hello']]
+        {"Content-Type" => "application/xml; charset=utf-16"},
+        ["Hello"]]
     }
 
-    get '/'
+    get "/"
     assert_response :success
 
-    assert_equal('utf-16', @response.charset)
+    assert_equal("utf-16", @response.charset)
     assert_equal(Mime[:xml], @response.content_type)
 
-    assert_equal('application/xml; charset=utf-16', @response.headers['Content-Type'])
+    assert_equal("application/xml; charset=utf-16", @response.headers["Content-Type"])
   end
 
   test "strong ETag validator" do
     @app = lambda { |env|
       ActionDispatch::Response.new.tap { |resp|
-        resp.strong_etag = '123'
-        resp.body = 'Hello'
+        resp.strong_etag = "123"
+        resp.body = "Hello"
         resp.request = ActionDispatch::Request.empty
       }.to_a
     }
 
-    get '/'
+    get "/"
     assert_response :ok
 
-    assert_equal('"202cb962ac59075b964b07152d234b70"', @response.headers['ETag'])
+    assert_equal('"202cb962ac59075b964b07152d234b70"', @response.headers["ETag"])
     assert_equal('"202cb962ac59075b964b07152d234b70"', @response.etag)
   end
 end