diff options
| author | schneems <richard.schneeman@gmail.com> | 2014-05-07 12:01:34 -0500 |
|---|---|---|
| committer | schneems <richard.schneeman@gmail.com> | 2014-05-07 12:01:34 -0500 |
| commit | ca97ec509955d70bde47d337e5086920f0c79b63 (patch) | |
| tree | ebc92027607789b0cd1a777c32dfdda54ed08789 /actionpack/test/dispatch/header_test.rb | |
| parent | 98baa827ac5e3a7e0fd427febed066d013198371 (diff) | |
| download | rails-ca97ec509955d70bde47d337e5086920f0c79b63.tar.gz rails-ca97ec509955d70bde47d337e5086920f0c79b63.tar.bz2 rails-ca97ec509955d70bde47d337e5086920f0c79b63.zip | |
HTTP::Headers#key? correctly converts
Previously if you were looking for a given key, the header may incorrectly tell you that it did not exist even though it would return a valid value:
```ruby
env = { "CONTENT_TYPE" => "text/plain" }
headers = ActionDispatch::Http::Headers.new(env)
headers["Content-Type"]
# => "text/plain"
headers.key?("Content-Type")
# => false
```
This PR fixes that behavior by converting the key before checking for presence
Diffstat (limited to 'actionpack/test/dispatch/header_test.rb')
| -rw-r--r-- | actionpack/test/dispatch/header_test.rb | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/actionpack/test/dispatch/header_test.rb b/actionpack/test/dispatch/header_test.rb index 9e37b96951..e2b38c23bc 100644 --- a/actionpack/test/dispatch/header_test.rb +++ b/actionpack/test/dispatch/header_test.rb @@ -55,6 +55,8 @@ class HeaderTest < ActiveSupport::TestCase test "key?" do assert @headers.key?("CONTENT_TYPE") assert @headers.include?("CONTENT_TYPE") + assert @headers.key?("Content-Type") + assert @headers.include?("Content-Type") end test "fetch with block" do |