diff options
author | Sebastian Sogamoso <sebasoga@gmail.com> | 2013-03-11 08:00:19 -0500 |
---|---|---|
committer | Sebastian Sogamoso <sebasoga@gmail.com> | 2013-03-11 09:28:22 -0500 |
commit | b3f894c5282244b41221f98dfac5296cea5a4485 (patch) | |
tree | 6408e5e79c0d101607590262d7746339f5a44e5b /actionpack/test/dispatch/debug_exceptions_test.rb | |
parent | 6e5ab6fccb55727ef2e32c30a77a48c595316cae (diff) | |
download | rails-b3f894c5282244b41221f98dfac5296cea5a4485.tar.gz rails-b3f894c5282244b41221f98dfac5296cea5a4485.tar.bz2 rails-b3f894c5282244b41221f98dfac5296cea5a4485.zip |
Change ActionController::Parameters#require behavior when value is empty
When the value for the required key is empty an ActionController::ParameterMissing is raised which gets caught by ActionController::Base and turned into a 400 Bad Request reply with a message in the body saying the key is missing, which is misleading.
With these changes, ActionController::EmptyParameter will be raised which ActionController::Base will catch and turn into a 400 Bad Request reply with a message in the body saying the key value is empty.
Diffstat (limited to 'actionpack/test/dispatch/debug_exceptions_test.rb')
-rw-r--r-- | actionpack/test/dispatch/debug_exceptions_test.rb | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/actionpack/test/dispatch/debug_exceptions_test.rb b/actionpack/test/dispatch/debug_exceptions_test.rb index 6035f0361e..9fafc3a0e9 100644 --- a/actionpack/test/dispatch/debug_exceptions_test.rb +++ b/actionpack/test/dispatch/debug_exceptions_test.rb @@ -41,6 +41,8 @@ class DebugExceptionsTest < ActionDispatch::IntegrationTest raise ActionController::UrlGenerationError, "No route matches" when "/parameter_missing" raise ActionController::ParameterMissing, :missing_param_key + when "/required_key_empty_value" + raise ActionController::EmptyParameter, :empty_param_key else raise "puke!" end @@ -120,6 +122,10 @@ class DebugExceptionsTest < ActionDispatch::IntegrationTest get "/parameter_missing", {}, {'action_dispatch.show_exceptions' => true} assert_response 400 assert_match(/ActionController::ParameterMissing/, body) + + get "/required_key_empty_value", {}, {'action_dispatch.show_exceptions' => true} + assert_response 400 + assert_match(/ActionController::EmptyParameter/, body) end test "does not show filtered parameters" do |