diff options
author | Xavier Noria <fxn@hashref.com> | 2015-08-28 16:23:31 +0200 |
---|---|---|
committer | Xavier Noria <fxn@hashref.com> | 2015-08-28 17:15:20 +0200 |
commit | cbe7899f9d5fece4749f75828fd120d67056f356 (patch) | |
tree | 6601a582e3945928194bf3ac5b8f40c39c8d7ec9 /actionpack/test/controller/required_params_test.rb | |
parent | 35df925b475f2f9fc593c4a1caf5009e5c970b0d (diff) | |
download | rails-cbe7899f9d5fece4749f75828fd120d67056f356.tar.gz rails-cbe7899f9d5fece4749f75828fd120d67056f356.tar.bz2 rails-cbe7899f9d5fece4749f75828fd120d67056f356.zip |
revises 877e42e
* A string in the example lacked quotes.
* The tests asserted stuff about :last_name, whereas
test params do not have that key.
* But, the first one passed, why? After hitting my head against
the wall and doing some obscure rituals realized the new
#require had an important typo, wanted to iterate over the
array argument (key), but it ran over its own hash keys
(method #keys).
* Modified the test to prevent the same typo to happen again.
* The second test assigned to an unused variable safe_params
that has been therefore removed.
* Grammar of the second test description.
* Since I was on it, reworded both test descriptions.
Diffstat (limited to 'actionpack/test/controller/required_params_test.rb')
-rw-r--r-- | actionpack/test/controller/required_params_test.rb | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/actionpack/test/controller/required_params_test.rb b/actionpack/test/controller/required_params_test.rb index 98b8e44b22..168f64ce41 100644 --- a/actionpack/test/controller/required_params_test.rb +++ b/actionpack/test/controller/required_params_test.rb @@ -49,20 +49,20 @@ class ParametersRequireTest < ActiveSupport::TestCase end end - test "require array of params" do - safe_params = ActionController::Parameters.new(person: {first_name: 'Gaurish', title: 'Mjallo'}) + test "require array when all required params are present" do + safe_params = ActionController::Parameters.new(person: {first_name: 'Gaurish', title: 'Mjallo', city: 'Barcelona'}) .require(:person) - .require([:first_name, :last_name]) + .require([:first_name, :title]) assert_kind_of Array, safe_params assert_equal ['Gaurish', 'Mjallo'], safe_params end - test "require array when it contains a nil values" do + test "require array when a required param is missing" do assert_raises(ActionController::ParameterMissing) do - safe_params = ActionController::Parameters.new(person: {first_name: 'Gaurish', title: nil}) + ActionController::Parameters.new(person: {first_name: 'Gaurish', title: nil}) .require(:person) - .require([:first_name, :last_name]) + .require([:first_name, :title]) end end end |