diff options
author | Sebastian Sogamoso <sebasoga@gmail.com> | 2013-03-11 08:00:19 -0500 |
---|---|---|
committer | Sebastian Sogamoso <sebasoga@gmail.com> | 2013-03-11 09:28:22 -0500 |
commit | b3f894c5282244b41221f98dfac5296cea5a4485 (patch) | |
tree | 6408e5e79c0d101607590262d7746339f5a44e5b /actionpack/test/controller/parameters | |
parent | 6e5ab6fccb55727ef2e32c30a77a48c595316cae (diff) | |
download | rails-b3f894c5282244b41221f98dfac5296cea5a4485.tar.gz rails-b3f894c5282244b41221f98dfac5296cea5a4485.tar.bz2 rails-b3f894c5282244b41221f98dfac5296cea5a4485.zip |
Change ActionController::Parameters#require behavior when value is empty
When the value for the required key is empty an ActionController::ParameterMissing is raised which gets caught by ActionController::Base and turned into a 400 Bad Request reply with a message in the body saying the key is missing, which is misleading.
With these changes, ActionController::EmptyParameter will be raised which ActionController::Base will catch and turn into a 400 Bad Request reply with a message in the body saying the key value is empty.
Diffstat (limited to 'actionpack/test/controller/parameters')
-rw-r--r-- | actionpack/test/controller/parameters/parameters_require_test.rb | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/actionpack/test/controller/parameters/parameters_require_test.rb b/actionpack/test/controller/parameters/parameters_require_test.rb index bdaba8d2d8..21b3eaa6b5 100644 --- a/actionpack/test/controller/parameters/parameters_require_test.rb +++ b/actionpack/test/controller/parameters/parameters_require_test.rb @@ -2,8 +2,14 @@ require 'abstract_unit' require 'action_controller/metal/strong_parameters' class ParametersRequireTest < ActiveSupport::TestCase - test "required parameters must be present not merely not nil" do + test "required parameters must be present" do assert_raises(ActionController::ParameterMissing) do + ActionController::Parameters.new(name: {}).require(:person) + end + end + + test "required parameters can't be blank" do + assert_raises(ActionController::EmptyParameter) do ActionController::Parameters.new(person: {}).require(:person) end end |