Merge branch 'master' into nested_has_many_through

Conflicts:
	activerecord/lib/active_record/associations.rb
	activerecord/test/cases/associations/cascaded_eager_loading_test.rb

4 files changed, 141 insertions, 3 deletions

diff --git a/actionpack/test/controller/new_base/bare_metal_test.rb b/actionpack/test/controller/new_base/bare_metal_test.rb
index 8a06e8d2a0..44922cecff 100644
--- a/actionpack/test/controller/new_base/bare_metal_test.rb
+++ b/actionpack/test/controller/new_base/bare_metal_test.rb
@@ -24,4 +24,19 @@ module BareMetalTest
       assert_equal "Hello world", string
     end
   end
+
+  class HeadController < ActionController::Metal
+    include ActionController::Head
+
+    def index
+      head :not_found
+    end
+  end
+
+  class HeadTest < ActiveSupport::TestCase
+    test "head works on its own" do
+      status, headers, body = HeadController.action(:index).call(Rack::MockRequest.env_for("/"))
+      assert_equal 404, status
+    end
+  end
 end
diff --git a/actionpack/test/controller/new_base/render_once_test.rb b/actionpack/test/controller/new_base/render_once_test.rb
new file mode 100644
index 0000000000..3035ed4ff2
--- /dev/null
+++ b/actionpack/test/controller/new_base/render_once_test.rb
@@ -0,0 +1,86 @@
+require 'abstract_unit'
+
+module RenderTemplate
+  class RenderOnceController < ActionController::Base
+    layout false
+
+    RESOLVER = ActionView::FixtureResolver.new(
+      "test/a.html.erb"       => "a",
+      "test/b.html.erb"       => "<>",
+      "test/c.html.erb"       => "c",
+      "test/one.html.erb"     => "<%= render :once => 'result' %>",
+      "test/two.html.erb"     => "<%= render :once => 'result' %>",
+      "test/three.html.erb"   => "<%= render :once => 'result' %>",
+      "test/result.html.erb"  => "YES!",
+      "other/result.html.erb" => "NO!",
+      "layouts/test.html.erb" => "l<%= yield %>l"
+    )
+
+    self.view_paths = [RESOLVER]
+
+    def _prefix
+      "test"
+    end
+
+    def multiple
+      render :once => %w(a b c)
+    end
+
+    def once
+      render :once => %w(one two three)
+    end
+
+    def duplicate
+      render :once => %w(a a a)
+    end
+
+    def with_layout
+      render :once => %w(a b c), :layout => "test"
+    end
+
+    def with_prefix
+      render :once => "result", :prefix => "other"
+    end
+
+    def with_nil_prefix
+      render :once => "test/result", :prefix => nil
+    end
+  end
+
+  module Tests
+    def test_mutliple_arguments_get_all_rendered
+      get :multiple
+      assert_response "a\n<>\nc"
+    end
+
+    def test_referenced_templates_get_rendered_once
+      get :once
+      assert_response "YES!\n\n"
+    end
+
+    def test_duplicated_templates_get_rendered_once
+      get :duplicate
+      assert_response "a"
+    end
+
+    def test_layout_wraps_all_rendered_templates
+      get :with_layout
+      assert_response "la\n<>\ncl"
+    end
+
+    def test_with_prefix_option
+      get :with_prefix
+      assert_response "NO!"
+    end
+
+    def test_with_nil_prefix_option
+      get :with_nil_prefix
+      assert_response "YES!"
+    end
+  end
+
+  class TestRenderOnce < Rack::TestCase
+    testing RenderTemplate::RenderOnceController
+    include Tests
+  end
+end
diff --git a/actionpack/test/controller/new_base/render_partial_test.rb b/actionpack/test/controller/new_base/render_partial_test.rb
index 5c7e66dba2..d800ea264d 100644
--- a/actionpack/test/controller/new_base/render_partial_test.rb
+++ b/actionpack/test/controller/new_base/render_partial_test.rb
@@ -5,10 +5,17 @@ module RenderPartial
   class BasicController < ActionController::Base
 
     self.view_paths = [ActionView::FixtureResolver.new(
-      "render_partial/basic/_basic.html.erb"    => "BasicPartial!",
-      "render_partial/basic/basic.html.erb"      => "<%= @test_unchanged = 'goodbye' %><%= render :partial => 'basic' %><%= @test_unchanged %>"
+      "render_partial/basic/_basic.html.erb"     => "BasicPartial!",
+      "render_partial/basic/basic.html.erb"      => "<%= @test_unchanged = 'goodbye' %><%= render :partial => 'basic' %><%= @test_unchanged %>",
+      "render_partial/basic/with_json.html.erb"  => "<%= render 'with_json.json' %>",
+      "render_partial/basic/_with_json.json.erb" => "<%= render 'final' %>",
+      "render_partial/basic/_final.json.erb"     => "{ final: json }"
     )]
 
+    def html_with_json_inside_json
+      render :action => "with_json"
+    end
+
     def changing
       @test_unchanged = 'hello'
       render :action => "basic"
@@ -22,6 +29,12 @@ module RenderPartial
       get :changing
       assert_response("goodbyeBasicPartial!goodbye")
     end
+
+    test "rendering a template with renders another partial with other format that renders other partial in the same format" do
+      get :html_with_json_inside_json
+      assert_content_type "text/html; charset=utf-8"
+      assert_response "{ final: json }"
+    end
   end
 
 end
diff --git a/actionpack/test/controller/new_base/render_template_test.rb b/actionpack/test/controller/new_base/render_template_test.rb
index fea98d6bbd..d31193a063 100644
--- a/actionpack/test/controller/new_base/render_template_test.rb
+++ b/actionpack/test/controller/new_base/render_template_test.rb
@@ -8,13 +8,21 @@ module RenderTemplate
       "shared.html.erb"          => "Elastica",
       "locals.html.erb"          => "The secret is <%= secret %>",
       "xml_template.xml.builder" => "xml.html do\n  xml.p 'Hello'\nend",
-      "with_raw.html.erb"        => "Hello <%=raw '<strong>this is raw</strong>' %>"
+      "with_raw.html.erb"        => "Hello <%=raw '<strong>this is raw</strong>' %>",
+      "test/with_json.html.erb"  => "<%= render :template => 'test/with_json.json' %>",
+      "test/with_json.json.erb"  => "<%= render :template => 'test/final' %>",
+      "test/final.json.erb"      => "{ final: json }",
+      "test/with_error.html.erb" => "<%= idontexist %>"
     )]
 
     def index
       render :template => "test/basic"
     end
 
+    def html_with_json_inside_json
+      render :template => "test/with_json"
+    end
+
     def index_without_key
       render "test/basic"
     end
@@ -42,6 +50,10 @@ module RenderTemplate
     def with_raw
       render :template => "with_raw"
     end
+
+    def with_error
+      render :template => "test/with_error"
+    end
   end
 
   class TestWithoutLayout < Rack::TestCase
@@ -88,6 +100,18 @@ module RenderTemplate
       assert_body "Hello <strong>this is raw</strong>"
       assert_status 200
     end
+
+    test "rendering a template with renders another template with other format that renders other template in the same format" do
+      get :html_with_json_inside_json
+      assert_content_type "text/html; charset=utf-8"
+      assert_response "{ final: json }"
+    end
+
+    test "rendering a template with error properly exceprts the code" do
+      get :with_error
+      assert_status 500
+      assert_match "undefined local variable or method `idontexist'", response.body
+    end
   end
 
   class WithLayoutController < ::ApplicationController