aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/controller/log_subscriber_test.rb
diff options
context:
space:
mode:
authorKasper Timm Hansen <kaspth@gmail.com>2016-08-07 19:59:13 +0200
committerKasper Timm Hansen <kaspth@gmail.com>2016-08-07 19:59:13 +0200
commitb377fc067d01b87779459baa0ec6896b6b7fa701 (patch)
treef5d465d930f441f6fb775ebb425a8ba7be038ede /actionpack/test/controller/log_subscriber_test.rb
parent6530fe6a251d4a4b32f876048dde1d846cfe4a17 (diff)
downloadrails-b377fc067d01b87779459baa0ec6896b6b7fa701.tar.gz
rails-b377fc067d01b87779459baa0ec6896b6b7fa701.tar.bz2
rails-b377fc067d01b87779459baa0ec6896b6b7fa701.zip
Assign config on base instead of on `@controller`.
In some test runs `ActionController::Base.enable_fragment_cache_logging` would be false, based on the test order. Turns out it was off because we assigned the config to the `@controller` variable, and not on `ActionController::Base`. The test failure was reproducible with, and now passes after this: ``` bin/test test/controller/log_subscriber_test.rb --seed 19918 ```
Diffstat (limited to 'actionpack/test/controller/log_subscriber_test.rb')
-rw-r--r--actionpack/test/controller/log_subscriber_test.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/actionpack/test/controller/log_subscriber_test.rb b/actionpack/test/controller/log_subscriber_test.rb
index 0deeb3865d..231283acdf 100644
--- a/actionpack/test/controller/log_subscriber_test.rb
+++ b/actionpack/test/controller/log_subscriber_test.rb
@@ -92,7 +92,7 @@ class ACLogSubscriberTest < ActionController::TestCase
def setup
super
- @controller.enable_fragment_cache_logging = true
+ ActionController::Base.enable_fragment_cache_logging = true
@old_logger = ActionController::Base.logger