aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/activerecord
diff options
context:
space:
mode:
authorPrem Sichanugrist <s@sikachu.com>2010-06-25 02:42:08 +0700
committerJosé Valim <jose.valim@gmail.com>2010-06-25 09:41:52 +0200
commit617e94658ddc3f71c42fc4f8c2346f87ff106bbe (patch)
treeeeeadd52c680a4b5369978dc4c5dcec3a9ea0901 /actionpack/test/activerecord
parenta12b76b09e98493c1e4aee147416ae5999402298 (diff)
downloadrails-617e94658ddc3f71c42fc4f8c2346f87ff106bbe.tar.gz
rails-617e94658ddc3f71c42fc4f8c2346f87ff106bbe.tar.bz2
rails-617e94658ddc3f71c42fc4f8c2346f87ff106bbe.zip
Make sure that Rails doesn't resent session_id cookie over and over again if it's already there [#2485 state:resolved]
This apply to only Active Record store and Memcached store, as they both store only the session_id, which will be unchanged, in the cookie. Signed-off-by: José Valim <jose.valim@gmail.com>
Diffstat (limited to 'actionpack/test/activerecord')
-rw-r--r--actionpack/test/activerecord/active_record_store_test.rb12
1 files changed, 12 insertions, 0 deletions
diff --git a/actionpack/test/activerecord/active_record_store_test.rb b/actionpack/test/activerecord/active_record_store_test.rb
index 736829dbf7..bdd1a0a15c 100644
--- a/actionpack/test/activerecord/active_record_store_test.rb
+++ b/actionpack/test/activerecord/active_record_store_test.rb
@@ -136,6 +136,18 @@ class ActiveRecordStoreTest < ActionController::IntegrationTest
end
end
+ def test_doesnt_write_session_cookie_if_session_id_is_already_exists
+ with_test_route_set do
+ get '/set_session_value'
+ assert_response :success
+ assert cookies['_session_id']
+
+ get '/get_session_value'
+ assert_response :success
+ assert_equal nil, headers['Set-Cookie'], "should not resend the cookie again if session_id cookie is already exists"
+ end
+ end
+
def test_prevents_session_fixation
with_test_route_set do
get '/set_session_value'