diff options
| author | Jon Moss <me@jonathanmoss.me> | 2017-01-05 17:39:12 -0500 |
|---|---|---|
| committer | Jon Moss <me@jonathanmoss.me> | 2017-01-05 17:39:12 -0500 |
| commit | c5da6414715e3e61f6e51a40245525aa9504a6f3 (patch) | |
| tree | 427d127b00c6316498dabbd5d13f5909d75d7177 /actionpack/lib | |
| parent | 5f03172f54a58a57a48a3121562beb2cef866cbe (diff) | |
| download | rails-c5da6414715e3e61f6e51a40245525aa9504a6f3.tar.gz rails-c5da6414715e3e61f6e51a40245525aa9504a6f3.tar.bz2 rails-c5da6414715e3e61f6e51a40245525aa9504a6f3.zip | |
Update `cookies` helper on all HTTP requests
Regression introduced by ae29142142324545a328948e059e8b8118fd7a33 / 8363b879fe759f0645179f4521cc64795efbee6e.
Previously, cookies were only updated on `GET` requests. Now we will
update the helper for all requests, as part of `process`. Added
regression tests for all available HTTP method helpers in
`ActionController::TestCase`.
Diffstat (limited to 'actionpack/lib')
| -rw-r--r-- | actionpack/lib/action_controller/test_case.rb | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/actionpack/lib/action_controller/test_case.rb b/actionpack/lib/action_controller/test_case.rb index 7b620ac95e..57dd605b51 100644 --- a/actionpack/lib/action_controller/test_case.rb +++ b/actionpack/lib/action_controller/test_case.rb @@ -389,9 +389,7 @@ module ActionController # Note that the request method is not verified. The different methods are # available to make the tests more expressive. def get(action, **args) - res = process(action, method: "GET", **args) - cookies.update res.cookies - res + process(action, method: "GET", **args) end # Simulate a POST request with the given parameters and set/volley the response. @@ -519,6 +517,7 @@ module ActionController unless @request.cookie_jar.committed? @request.cookie_jar.write(@response) cookies.update(@request.cookie_jar.instance_variable_get(:@cookies)) + cookies.update(@response.cookies) end end @response.prepare! |