aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib
diff options
context:
space:
mode:
authorChris Sinjakli <chris@sinjakli.co.uk>2014-09-14 12:22:29 +0200
committerChris Sinjakli <chris@sinjakli.co.uk>2014-12-15 14:51:07 +0000
commit8f8ccb9901cab457c6e1d52bdb25acf658fd5777 (patch)
treea98563a5c43183cf3a3f0ed5ddad3e73e9d88801 /actionpack/lib
parentc308fec0f543c5b5a95bf529b5885964ae8b0f61 (diff)
downloadrails-8f8ccb9901cab457c6e1d52bdb25acf658fd5777.tar.gz
rails-8f8ccb9901cab457c6e1d52bdb25acf658fd5777.tar.bz2
rails-8f8ccb9901cab457c6e1d52bdb25acf658fd5777.zip
Don't convert empty arrays to nils when deep munging params
Diffstat (limited to 'actionpack/lib')
-rw-r--r--actionpack/lib/action_controller/log_subscriber.rb9
-rw-r--r--actionpack/lib/action_dispatch/request/utils.rb4
2 files changed, 0 insertions, 13 deletions
diff --git a/actionpack/lib/action_controller/log_subscriber.rb b/actionpack/lib/action_controller/log_subscriber.rb
index d3f93a5352..87609d8aa7 100644
--- a/actionpack/lib/action_controller/log_subscriber.rb
+++ b/actionpack/lib/action_controller/log_subscriber.rb
@@ -53,15 +53,6 @@ module ActionController
end
end
- def deep_munge(event)
- debug do
- "Value for params[:#{event.payload[:keys].join('][:')}] was set "\
- "to nil, because it was one of [], [null] or [null, null, ...]. "\
- "Go to http://guides.rubyonrails.org/security.html#unsafe-query-generation "\
- "for more information."\
- end
- end
-
%w(write_fragment read_fragment exist_fragment?
expire_fragment expire_page write_page).each do |method|
class_eval <<-METHOD, __FILE__, __LINE__ + 1
diff --git a/actionpack/lib/action_dispatch/request/utils.rb b/actionpack/lib/action_dispatch/request/utils.rb
index 9d4f1aa3c5..1c9371d89c 100644
--- a/actionpack/lib/action_dispatch/request/utils.rb
+++ b/actionpack/lib/action_dispatch/request/utils.rb
@@ -16,10 +16,6 @@ module ActionDispatch
when Array
v.grep(Hash) { |x| deep_munge(x, keys) }
v.compact!
- if v.empty?
- hash[k] = nil
- ActiveSupport::Notifications.instrument("deep_munge.action_controller", keys: keys)
- end
when Hash
deep_munge(v, keys)
end