aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_view
diff options
context:
space:
mode:
authorRyan Bates <ryan@railscasts.com>2008-08-19 19:09:04 -0500
committerJoshua Peek <josh@joshpeek.com>2008-08-19 19:09:04 -0500
commita8ece12fe2ac7838407954453e0d31af6186a5db (patch)
tree5a6cb0a957bebc1da95c1918563db10447cacd26 /actionpack/lib/action_view
parent71c4ff07ab4313c1f4781d59ad2f4528f5875665 (diff)
downloadrails-a8ece12fe2ac7838407954453e0d31af6186a5db.tar.gz
rails-a8ece12fe2ac7838407954453e0d31af6186a5db.tar.bz2
rails-a8ece12fe2ac7838407954453e0d31af6186a5db.zip
Return nil instead of a space when passing an empty collection or nil to 'render :partial' [#791 state:resolved]
Signed-off-by: Joshua Peek <josh@joshpeek.com>
Diffstat (limited to 'actionpack/lib/action_view')
-rw-r--r--actionpack/lib/action_view/base.rb2
-rw-r--r--actionpack/lib/action_view/partials.rb2
2 files changed, 2 insertions, 2 deletions
diff --git a/actionpack/lib/action_view/base.rb b/actionpack/lib/action_view/base.rb
index 62a01b33dd..46bacbcbc1 100644
--- a/actionpack/lib/action_view/base.rb
+++ b/actionpack/lib/action_view/base.rb
@@ -263,7 +263,7 @@ module ActionView #:nodoc:
end
elsif options[:file]
render_file(options[:file], nil, options[:locals])
- elsif options[:partial] && options[:collection]
+ elsif options[:partial] && options.has_key?(:collection)
render_partial_collection(options[:partial], options[:collection], options[:spacer_template], options[:locals], options[:as])
elsif options[:partial]
render_partial(options[:partial], options[:object], options[:locals])
diff --git a/actionpack/lib/action_view/partials.rb b/actionpack/lib/action_view/partials.rb
index b661a62677..074ba5a2b5 100644
--- a/actionpack/lib/action_view/partials.rb
+++ b/actionpack/lib/action_view/partials.rb
@@ -161,7 +161,7 @@ module ActionView
end
def render_partial_collection(partial_path, collection, partial_spacer_template = nil, local_assigns = {}, as = nil) #:nodoc:
- return " " if collection.empty?
+ return nil if collection.blank?
local_assigns = local_assigns ? local_assigns.clone : {}
spacer = partial_spacer_template ? render(:partial => partial_spacer_template) : ''