diff options
| author | miloops <miloops@gmail.com> | 2008-07-31 19:44:11 -0300 |
|---|---|---|
| committer | Michael Koziarski <michael@koziarski.com> | 2008-08-08 15:31:02 +0200 |
| commit | ea0d036e31d984888303a79533ff872b787871ae (patch) | |
| tree | 8a6be72060277961f5e2cbf16c40c6b90f6e1fe0 /actionpack/lib/action_view/helpers | |
| parent | 7f6e7ba1f7e8735f1c3f30ba125b5432f00d2a70 (diff) | |
| download | rails-ea0d036e31d984888303a79533ff872b787871ae.tar.gz rails-ea0d036e31d984888303a79533ff872b787871ae.tar.bz2 rails-ea0d036e31d984888303a79533ff872b787871ae.zip | |
mail_to should use decodeURIcomponent instead of unescape to be utf friendly.
Signed-off-by: Michael Koziarski <michael@koziarski.com>
Diffstat (limited to 'actionpack/lib/action_view/helpers')
| -rw-r--r-- | actionpack/lib/action_view/helpers/url_helper.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/actionpack/lib/action_view/helpers/url_helper.rb b/actionpack/lib/action_view/helpers/url_helper.rb index f31502d99d..7ba42a3b72 100644 --- a/actionpack/lib/action_view/helpers/url_helper.rb +++ b/actionpack/lib/action_view/helpers/url_helper.rb @@ -442,7 +442,7 @@ module ActionView # # => <a href="mailto:me@domain.com">me@domain.com</a> # # mail_to "me@domain.com", "My email", :encode => "javascript" - # # => <script type="text/javascript">eval(unescape('%64%6f%63...%6d%65%6e'))</script> + # # => <script type="text/javascript">eval(decodeURIComponent('%64%6f%63...%27%29%3b'))</script> # # mail_to "me@domain.com", "My email", :encode => "hex" # # => <a href="mailto:%6d%65@%64%6f%6d%61%69%6e.%63%6f%6d">My email</a> @@ -476,7 +476,7 @@ module ActionView "document.write('#{content_tag("a", name || email_address_obfuscated, html_options.merge({ "href" => "mailto:"+email_address+extras }))}');".each_byte do |c| string << sprintf("%%%x", c) end - "<script type=\"#{Mime::JS}\">eval(unescape('#{string}'))</script>" + "<script type=\"#{Mime::JS}\">eval(decodeURIComponent('#{string}'))</script>" elsif encode == "hex" email_address_encoded = '' email_address_obfuscated.each_byte do |c| |