diff options
author | Carlos Galdino <carloshsgaldino@gmail.com> | 2012-06-01 19:10:18 -0300 |
---|---|---|
committer | Carlos Galdino <carloshsgaldino@gmail.com> | 2012-06-05 15:34:30 -0300 |
commit | fc092a9cba5fceec38358072e50e09250cf58840 (patch) | |
tree | 7b4181b267ec8bfe0f07eee77c2f496d122cf5a3 /actionpack/lib/action_view/helpers/url_helper.rb | |
parent | 9f52d1526c816a35ec7bcc6e85f27b51d010dbae (diff) | |
download | rails-fc092a9cba5fceec38358072e50e09250cf58840.tar.gz rails-fc092a9cba5fceec38358072e50e09250cf58840.tar.bz2 rails-fc092a9cba5fceec38358072e50e09250cf58840.zip |
Deprecate `:confirm` in favor of `:data => { :confirm => 'Text' }` option
This deprecation applies to:
`button_to`
`button_tag`
`image_submit_tag`
`link_to`
`submit_tag`
As :confirm is an UI specific option is better to use the data attributes,
teaching users about unobtrusive JavaScript and how Rails works with it.
Diffstat (limited to 'actionpack/lib/action_view/helpers/url_helper.rb')
-rw-r--r-- | actionpack/lib/action_view/helpers/url_helper.rb | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/actionpack/lib/action_view/helpers/url_helper.rb b/actionpack/lib/action_view/helpers/url_helper.rb index 6f05881d08..d044afa6e6 100644 --- a/actionpack/lib/action_view/helpers/url_helper.rb +++ b/actionpack/lib/action_view/helpers/url_helper.rb @@ -628,8 +628,13 @@ module ActionView html_options["data-disable-with"] = disable_with end - html_options["data-confirm"] = confirm if confirm - add_method_to_attributes!(html_options, method) if method + if confirm + ActiveSupport::Deprecation.warn ":confirm option is deprecated and will be removed from Rails 4.0. Use ':data => { :confirm => \'Text\' }' instead" + + html_options["data-confirm"] = confirm + end + + add_method_to_attributes!(html_options, method) if method html_options else |