aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_view/helpers/url_helper.rb
diff options
context:
space:
mode:
authorDavid Heinemeier Hansson <david@loudthinking.com>2007-09-22 17:19:26 +0000
committerDavid Heinemeier Hansson <david@loudthinking.com>2007-09-22 17:19:26 +0000
commit39de84d96739012d2b2d8fd76976bbd798cd2573 (patch)
treed5543bc3249b754eba1d5c5662a900defddfc455 /actionpack/lib/action_view/helpers/url_helper.rb
parenta7764d8fd491fb49f50397aa79d305bdb93552c5 (diff)
downloadrails-39de84d96739012d2b2d8fd76976bbd798cd2573.tar.gz
rails-39de84d96739012d2b2d8fd76976bbd798cd2573.tar.bz2
rails-39de84d96739012d2b2d8fd76976bbd798cd2573.zip
Fixed that setting the :host option in url_for would automatically turn off :only_path (since :host would otherwise not be shown) (closes #9586) [Bounga]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
Diffstat (limited to 'actionpack/lib/action_view/helpers/url_helper.rb')
-rw-r--r--actionpack/lib/action_view/helpers/url_helper.rb5
1 files changed, 3 insertions, 2 deletions
diff --git a/actionpack/lib/action_view/helpers/url_helper.rb b/actionpack/lib/action_view/helpers/url_helper.rb
index 01427f8bb8..76963a20b3 100644
--- a/actionpack/lib/action_view/helpers/url_helper.rb
+++ b/actionpack/lib/action_view/helpers/url_helper.rb
@@ -20,7 +20,7 @@ module ActionView
#
# ==== Options
# * <tt>:anchor</tt> -- specifies the anchor name to be appended to the path.
- # * <tt>:only_path</tt> -- if true, returns the relative URL (omitting the protocol, host name, and port) (<tt>true</tt> by default)
+ # * <tt>:only_path</tt> -- if true, returns the relative URL (omitting the protocol, host name, and port) (<tt>true</tt> by default unless <tt>:host</tt> is specified)
# * <tt>:trailing_slash</tt> -- if true, adds a trailing slash, as in "/archive/2005/". Note that this
# is currently not recommended since it breaks caching.
# * <tt>:host</tt> -- overrides the default (current) host if provided
@@ -65,7 +65,8 @@ module ActionView
def url_for(options = {})
case options
when Hash
- options = { :only_path => true }.update(options.symbolize_keys)
+ show_path = options[:host].nil? ? true : false
+ options = { :only_path => show_path }.update(options.symbolize_keys)
escape = options.key?(:escape) ? options.delete(:escape) : true
url = @controller.send(:url_for, options)
when String