aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_view/helpers/tags/base.rb
diff options
context:
space:
mode:
authorRafael Mendonça França <rafael.franca@plataformatec.com.br>2012-05-13 00:47:34 -0300
committerRafael Mendonça França <rafaelmfranca@gmail.com>2012-05-13 01:00:31 -0300
commit521e964411114a9ff8c95f4129ca7ade8f972d53 (patch)
treef748930bc4ec797ba706f6d122c7c9e9f9a8be00 /actionpack/lib/action_view/helpers/tags/base.rb
parent30818561158dce27f3b0ae3f659a7bfdc867b834 (diff)
downloadrails-521e964411114a9ff8c95f4129ca7ade8f972d53.tar.gz
rails-521e964411114a9ff8c95f4129ca7ade8f972d53.tar.bz2
rails-521e964411114a9ff8c95f4129ca7ade8f972d53.zip
Do not add `:include_blank` option if prompt is present
Diffstat (limited to 'actionpack/lib/action_view/helpers/tags/base.rb')
-rw-r--r--actionpack/lib/action_view/helpers/tags/base.rb6
1 files changed, 3 insertions, 3 deletions
diff --git a/actionpack/lib/action_view/helpers/tags/base.rb b/actionpack/lib/action_view/helpers/tags/base.rb
index 607954e762..380ebe4b65 100644
--- a/actionpack/lib/action_view/helpers/tags/base.rb
+++ b/actionpack/lib/action_view/helpers/tags/base.rb
@@ -121,7 +121,7 @@ module ActionView
def select_content_tag(option_tags, options, html_options)
html_options = html_options.stringify_keys
add_default_name_and_id(html_options)
- options[:include_blank] ||= true if option_required?(html_options)
+ options[:include_blank] ||= true unless options[:prompt] || select_not_required?(html_options)
select = content_tag("select", add_options(option_tags, options, value(object)), html_options)
if html_options["multiple"] && options.fetch(:include_hidden, true)
@@ -131,8 +131,8 @@ module ActionView
end
end
- def option_required?(html_options)
- html_options["required"] && !html_options["multiple"] && !(html_options["size"].to_i > 1)
+ def select_not_required?(html_options)
+ !html_options["required"] || html_options["multiple"] || html_options["size"].to_i > 1
end
def add_options(option_tags, options, value = nil)