Fixed all helpers so that they use XHTML compliant double quotes for values instead of single quotes [htonl/bitsweat]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@114 5ecf4fe2-1ee6-0310-87b1-e25e094e27de

1 files changed, 6 insertions, 8 deletions

diff --git a/actionpack/lib/action_view/helpers/tag_helper.rb b/actionpack/lib/action_view/helpers/tag_helper.rb
index 13aa9297ca..6139943567 100644
--- a/actionpack/lib/action_view/helpers/tag_helper.rb
+++ b/actionpack/lib/action_view/helpers/tag_helper.rb
@@ -10,7 +10,7 @@ module ActionView
       # * tag("br") => <br />
       # * tag("input", { "type" => "text"}) => <input type="text" />
       def tag(name, options = {}, open = false)
-        "<#{name + tag_options(options)}" + (open ? ">" : " />")
+        "<#{name}#{tag_options(options)}" + (open ? ">" : " />")
       end
       
       # Examples: 
@@ -18,7 +18,7 @@ module ActionView
       # * content_tag("div", content_tag("p", "Hello world!"), "class" => "strong") => 
       #   <div class="strong"><p>Hello world!</p></div>
       def content_tag(name, content, options = {})
-        "<#{name + tag_options(options)}>#{content}</#{name}>"
+        "<#{name}#{tag_options(options)}>#{content}</#{name}>"
       end
 
       # Starts a form tag that points the action to an url configured with <tt>url_for_options</tt> just like 
@@ -46,12 +46,10 @@ module ActionView
 
       private
         def tag_options(options)
-          if options.empty?
-            ""
-          else
-            " " + options.collect { |pair| 
-              "#{pair.first}=\"#{html_escape(pair.last)}\"" 
-            }.sort.join(" ") 
+          unless options.empty?
+            " " + options.map { |key, value|
+              %(#{key}="#{html_escape(value)}")
+            }.sort.join(" ")
           end
         end
     end