diff options
| author | Jon Leighton <j@jonathanleighton.com> | 2011-05-14 19:45:26 +0100 |
|---|---|---|
| committer | Jon Leighton <j@jonathanleighton.com> | 2011-05-14 19:49:22 +0100 |
| commit | 7e6145b4a2108a4ad94af02c3070789c03ccbd00 (patch) | |
| tree | a37f8547283a6d111918d612d2e3ab34fc743178 /actionpack/lib/action_view/helpers/form_helper.rb | |
| parent | 60b23ea1da1c119eaab6d07e5a03cf3b5d5577d4 (diff) | |
| download | rails-7e6145b4a2108a4ad94af02c3070789c03ccbd00.tar.gz rails-7e6145b4a2108a4ad94af02c3070789c03ccbd00.tar.bz2 rails-7e6145b4a2108a4ad94af02c3070789c03ccbd00.zip | |
These extra array operations appear to be unnecessary. Reasoning:
* It is not necessary to subtract 'id' from the list of copied attributes because record and mem_record are equal, so therefore their id attributes are also equal (so there is no harm in copying it, and this reduces the complexity of the code)
* It is not necessary to intersect the attribute names, since record and mem_record are equal, so they have the same id and class, so they have the same columns in the database. If record has non-column attributes then it seems reasonable to also copy them onto mem_record (though I am not sure what situation this would ever happen in)
Diffstat (limited to 'actionpack/lib/action_view/helpers/form_helper.rb')
0 files changed, 0 insertions, 0 deletions