diff options
| author | Bernerd Schaefer <bj.schaefer@gmail.com> | 2015-09-04 12:23:29 -0700 |
|---|---|---|
| committer | Bernerd Schaefer <bj.schaefer@gmail.com> | 2015-09-04 13:42:32 -0700 |
| commit | ee63532d40c9e06d5b38e9a2e98e00fbbe084064 (patch) | |
| tree | 102ecaa1c09ef3cdc7bf7941912986160f673e94 /actionpack/lib/action_dispatch | |
| parent | 451b954c2f072d08e13fc2552f3dfa35d93b0935 (diff) | |
| download | rails-ee63532d40c9e06d5b38e9a2e98e00fbbe084064.tar.gz rails-ee63532d40c9e06d5b38e9a2e98e00fbbe084064.tar.bz2 rails-ee63532d40c9e06d5b38e9a2e98e00fbbe084064.zip | |
`url_for` does not modify polymorphic options
The `url_for` methods in `actionpack` and `actionview`
now make a copy of the provided options
before generating polymorphic paths or URLs.
The bug in the previous behavior
is most noticeable in a case like:
url_options = [:new, :post, param: 'value']
if current_page?(url_options)
css_class = "active"
end
link_to "New Post", url_options, class: css_class
Diffstat (limited to 'actionpack/lib/action_dispatch')
| -rw-r--r-- | actionpack/lib/action_dispatch/routing/url_for.rb | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/actionpack/lib/action_dispatch/routing/url_for.rb b/actionpack/lib/action_dispatch/routing/url_for.rb index 967bbd62f8..883cd9c2c3 100644 --- a/actionpack/lib/action_dispatch/routing/url_for.rb +++ b/actionpack/lib/action_dispatch/routing/url_for.rb @@ -180,7 +180,8 @@ module ActionDispatch when Symbol HelperMethodBuilder.url.handle_string_call self, options when Array - polymorphic_url(options, options.extract_options!) + components = options.dup + polymorphic_url(components, components.extract_options!) when Class HelperMethodBuilder.url.handle_class_call self, options else |