diff options
author | Alireza Bashiri <azbshiri@gmail.com> | 2018-07-20 15:18:49 +0430 |
---|---|---|
committer | Alireza Bashiri <azbshiri@gmail.com> | 2018-07-20 15:18:49 +0430 |
commit | 9b51ee9f925e9c1f64d0bae2039ff70cea0d0959 (patch) | |
tree | 814d463548ba6732087877d99f30a1fd19cd8c96 /actionpack/lib/action_dispatch | |
parent | 01429a665c1eadd20a64ca25d36190a9d9b555b1 (diff) | |
download | rails-9b51ee9f925e9c1f64d0bae2039ff70cea0d0959.tar.gz rails-9b51ee9f925e9c1f64d0bae2039ff70cea0d0959.tar.bz2 rails-9b51ee9f925e9c1f64d0bae2039ff70cea0d0959.zip |
Prevent `RequestEncoder#encode_params` to parse falsey params
When a `get` method called with `as: :json` and `params: nil` or
`params: false` (explicitly or implicitly)
`RequestEncoder#encode_params` converts it into a `null` or `false`
value which includes a unexpected `null=` or `false` query string into
request URL. From now on `RequestEncoder#encode_params` checks whether
`params` is nil or not otherwise returns.
Move down `nil` conversion guard
Update CHANGELOG.md
Diffstat (limited to 'actionpack/lib/action_dispatch')
-rw-r--r-- | actionpack/lib/action_dispatch/testing/request_encoder.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/actionpack/lib/action_dispatch/testing/request_encoder.rb b/actionpack/lib/action_dispatch/testing/request_encoder.rb index 01246b7a2e..9889f61951 100644 --- a/actionpack/lib/action_dispatch/testing/request_encoder.rb +++ b/actionpack/lib/action_dispatch/testing/request_encoder.rb @@ -34,7 +34,7 @@ module ActionDispatch end def encode_params(params) - @param_encoder.call(params) + @param_encoder.call(params) if params end def self.parser(content_type) |