diff options
author | Guillermo Iguaran <guilleiguaran@gmail.com> | 2014-11-16 14:27:12 -0500 |
---|---|---|
committer | Guillermo Iguaran <guilleiguaran@gmail.com> | 2014-11-16 14:27:12 -0500 |
commit | 3a804aab9557efd1f1f3b68a5d1e9e3c2f37df20 (patch) | |
tree | 4eda2e37e78ef5097e38c668f0d446ba61b4767e /actionpack/lib/action_dispatch | |
parent | 7830bb0d9d01b125755e226ffdca8a0f2cc7d00f (diff) | |
parent | 20ad04e5fcfd5b972bfffb6c47b44646c41b8a82 (diff) | |
download | rails-3a804aab9557efd1f1f3b68a5d1e9e3c2f37df20.tar.gz rails-3a804aab9557efd1f1f3b68a5d1e9e3c2f37df20.tar.bz2 rails-3a804aab9557efd1f1f3b68a5d1e9e3c2f37df20.zip |
Merge pull request #17630 from gsamokovarov/exception-wrapper-source-extract
Rename #source_extract to #source_extracts in ExceptionWrapper
Diffstat (limited to 'actionpack/lib/action_dispatch')
3 files changed, 8 insertions, 8 deletions
diff --git a/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb b/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb index 9755d949e7..c1562fcc0d 100644 --- a/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb +++ b/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb @@ -53,7 +53,7 @@ module ActionDispatch show_source_idx: source_to_show_id, trace_to_show: trace_to_show, routes_inspector: routes_inspector(exception), - source_extract: wrapper.source_extract, + source_extracts: wrapper.source_extracts, line_number: wrapper.line_number, file: wrapper.file ) diff --git a/actionpack/lib/action_dispatch/middleware/exception_wrapper.rb b/actionpack/lib/action_dispatch/middleware/exception_wrapper.rb index edd98c5cf2..a4862e33aa 100644 --- a/actionpack/lib/action_dispatch/middleware/exception_wrapper.rb +++ b/actionpack/lib/action_dispatch/middleware/exception_wrapper.rb @@ -85,13 +85,13 @@ module ActionDispatch Rack::Utils.status_code(@@rescue_responses[class_name]) end - def source_extract + def source_extracts backtrace.map do |trace| file, line = trace.split(":") line_number = line.to_i + { code: source_fragment(file, line_number), - file: file, line_number: line_number } end diff --git a/actionpack/lib/action_dispatch/middleware/templates/rescues/_source.erb b/actionpack/lib/action_dispatch/middleware/templates/rescues/_source.erb index 101cea13f9..e7b913bbe4 100644 --- a/actionpack/lib/action_dispatch/middleware/templates/rescues/_source.erb +++ b/actionpack/lib/action_dispatch/middleware/templates/rescues/_source.erb @@ -1,22 +1,22 @@ -<% @source_extract.each_with_index do |extract_source, index| %> - <% if extract_source[:code] %> +<% @source_extracts.each_with_index do |source_extract, index| %> + <% if source_extract[:code] %> <div class="source <%="hidden" if @show_source_idx != index%>" id="frame-source-<%=index%>"> <div class="info"> - Extracted source (around line <strong>#<%= extract_source[:line_number] %></strong>): + Extracted source (around line <strong>#<%= source_extract[:line_number] %></strong>): </div> <div class="data"> <table cellpadding="0" cellspacing="0" class="lines"> <tr> <td> <pre class="line_numbers"> - <% extract_source[:code].each_key do |line_number| %> + <% source_extract[:code].each_key do |line_number| %> <span><%= line_number -%></span> <% end %> </pre> </td> <td width="100%"> <pre> -<% extract_source[:code].each do |line, source| -%><div class="line<%= " active" if line == extract_source[:line_number] -%>"><%= source -%></div><% end -%> +<% source_extract[:code].each do |line, source| -%><div class="line<%= " active" if line == source_extract[:line_number] -%>"><%= source -%></div><% end -%> </pre> </td> </tr> |