aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch
diff options
context:
space:
mode:
authorAaron Patterson <aaron.patterson@gmail.com>2015-08-08 16:39:16 -0700
committerAaron Patterson <aaron.patterson@gmail.com>2015-08-08 16:39:16 -0700
commit1b73d53a1c45933017dd10d2edc506a4982c4c0d (patch)
tree9fe59e46b658cd615bdc7ec3fb1e08630b26d1ad /actionpack/lib/action_dispatch
parentdc1b937db780155089fce522f03d340e62f5df36 (diff)
downloadrails-1b73d53a1c45933017dd10d2edc506a4982c4c0d.tar.gz
rails-1b73d53a1c45933017dd10d2edc506a4982c4c0d.tar.bz2
rails-1b73d53a1c45933017dd10d2edc506a4982c4c0d.zip
eliminate assignment in conditional
The method we called already has the conditional we need. Just add an else block so that we don't need two tests.
Diffstat (limited to 'actionpack/lib/action_dispatch')
-rw-r--r--actionpack/lib/action_dispatch/routing/route_set.rb4
1 files changed, 3 insertions, 1 deletions
diff --git a/actionpack/lib/action_dispatch/routing/route_set.rb b/actionpack/lib/action_dispatch/routing/route_set.rb
index cc86890c0a..d58293d93b 100644
--- a/actionpack/lib/action_dispatch/routing/route_set.rb
+++ b/actionpack/lib/action_dispatch/routing/route_set.rb
@@ -35,7 +35,7 @@ module ActionDispatch
prepare_params!(params)
# Just raise undefined constant errors if a controller was specified as default.
- unless controller = controller(params, @raise_on_name_error)
+ controller = controller(params, @raise_on_name_error) do
return [404, {'X-Cascade' => 'pass'}, []]
end
@@ -57,6 +57,8 @@ module ActionDispatch
if params && params.key?(:controller)
controller_param = params[:controller]
controller_reference(controller_param)
+ else
+ yield
end
rescue NameError => e
raise ActionController::RoutingError, e.message, e.backtrace if raise_on_name_error