aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch/routing
diff options
context:
space:
mode:
authorAaron Lasseigne <aaron.lasseigne@gmail.com>2015-08-07 16:37:59 -0500
committerAaron Lasseigne <aaron.lasseigne@gmail.com>2015-08-08 11:54:09 -0500
commit725f9bf3e284cedf09bdd26712cfa5c7f39a08e0 (patch)
tree6874b32587001aa5fdb2bf20584815c3c03147f1 /actionpack/lib/action_dispatch/routing
parent9645820bdb4d8cd131c855a243d2fbc636a11908 (diff)
downloadrails-725f9bf3e284cedf09bdd26712cfa5c7f39a08e0.tar.gz
rails-725f9bf3e284cedf09bdd26712cfa5c7f39a08e0.tar.bz2
rails-725f9bf3e284cedf09bdd26712cfa5c7f39a08e0.zip
replace each with each_key when only the key is needed
Using each_key is faster and more intention revealing. Calculating ------------------------------------- each 31.378k i/100ms each_key 33.790k i/100ms ------------------------------------------------- each 450.225k (± 7.0%) i/s - 2.259M each_key 494.459k (± 6.3%) i/s - 2.467M Comparison: each_key: 494459.4 i/s each: 450225.1 i/s - 1.10x slower
Diffstat (limited to 'actionpack/lib/action_dispatch/routing')
-rw-r--r--actionpack/lib/action_dispatch/routing/route_set.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/actionpack/lib/action_dispatch/routing/route_set.rb b/actionpack/lib/action_dispatch/routing/route_set.rb
index f3d7a234d7..1b9a098514 100644
--- a/actionpack/lib/action_dispatch/routing/route_set.rb
+++ b/actionpack/lib/action_dispatch/routing/route_set.rb
@@ -267,7 +267,7 @@ module ActionDispatch
path_params -= controller_options.keys
path_params -= result.keys
end
- inner_options.each do |key, _|
+ inner_options.each_key do |key|
path_params.delete(key)
end