diff options
| author | Kir Shatrov <shatrov@me.com> | 2014-12-01 17:45:33 -0500 |
|---|---|---|
| committer | Kir Shatrov <shatrov@me.com> | 2014-12-02 09:45:20 -0500 |
| commit | 083f657c0f1990e980d33f89f44d8943a9270475 (patch) | |
| tree | 9477e1ee32eb0384059d2d57b064b27d5023c08a /actionpack/lib/action_dispatch/middleware/templates/rescues | |
| parent | cd77755ae46616f24ae0ad2e586be528bb326be1 (diff) | |
| download | rails-083f657c0f1990e980d33f89f44d8943a9270475.tar.gz rails-083f657c0f1990e980d33f89f44d8943a9270475.tar.bz2 rails-083f657c0f1990e980d33f89f44d8943a9270475.zip | |
Refactor debug view
Avoid logic in ERB and use helpers
Diffstat (limited to 'actionpack/lib/action_dispatch/middleware/templates/rescues')
| -rw-r--r-- | actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb | 23 |
1 files changed, 2 insertions, 21 deletions
diff --git a/actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb b/actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb index 761cd0ffcc..49b1e83551 100644 --- a/actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb +++ b/actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb @@ -5,27 +5,8 @@ <pre id="blame_trace" <%='style="display:none"' if hide %>><code><%= @exception.describe_blame %></code></pre> <% end %> -<% - clean_params = @request.filtered_parameters.clone - clean_params.delete("action") - clean_params.delete("controller") - - request_dump = if clean_params.empty? - 'None' - else - pretty_params = "" - PP.pp(clean_params, pretty_params, 200) - - pretty_params - end - - def debug_hash(object) - object.to_hash.sort_by { |k, _| k.to_s }.map { |k, v| "#{k}: #{v.inspect rescue $!.message}" }.join("\n") - end unless self.class.method_defined?(:debug_hash) -%> - <h2 style="margin-top: 30px">Request</h2> -<p><b>Parameters</b>:</p> <pre><%= request_dump %></pre> +<p><b>Parameters</b>:</p> <pre><%= debug_params(@request.filtered_parameters) %></pre> <div class="details"> <div class="summary"><a href="#" onclick="return toggleSessionDump()">Toggle session dump</a></div> @@ -38,4 +19,4 @@ </div> <h2 style="margin-top: 30px">Response</h2> -<p><b>Headers</b>:</p> <pre><%= defined?(@response) ? @response.headers.inspect.gsub(',', ",\n") : 'None' %></pre> +<p><b>Headers</b>:</p> <pre><%= debug_headers(defined?(@response) ? @response.headers : {}) %></pre> |