aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch/http/content_security_policy.rb
diff options
context:
space:
mode:
authorAndrew White <andrew.white@unboxed.co>2018-02-19 12:00:29 +0000
committerAndrew White <andrew.white@unboxed.co>2018-02-19 12:00:29 +0000
commit52a1f1c226c2238e16d1a4d32faa8d1e6a36a26f (patch)
tree7c222df8b38bdd3cb285c95b0dd067ed9c63ae1b /actionpack/lib/action_dispatch/http/content_security_policy.rb
parentf712ef27c55fc4210a722d447e05271adef1e57f (diff)
downloadrails-52a1f1c226c2238e16d1a4d32faa8d1e6a36a26f.tar.gz
rails-52a1f1c226c2238e16d1a4d32faa8d1e6a36a26f.tar.bz2
rails-52a1f1c226c2238e16d1a4d32faa8d1e6a36a26f.zip
Revert "Merge pull request #32045 from eagletmt/skip-csp-header"
This reverts commit 86f7c269073a3a9e6ddec9b957deaa2716f2627d, reversing changes made to 5ece2e4a4459065b5efd976aebd209bbf0cab89b. If a policy is set then we should generate it even if it's empty. However what is happening is that we're accidentally generating an empty policy when the initializer is commented out by default.
Diffstat (limited to 'actionpack/lib/action_dispatch/http/content_security_policy.rb')
-rw-r--r--actionpack/lib/action_dispatch/http/content_security_policy.rb12
1 files changed, 2 insertions, 10 deletions
diff --git a/actionpack/lib/action_dispatch/http/content_security_policy.rb b/actionpack/lib/action_dispatch/http/content_security_policy.rb
index 160c345361..4883e23d24 100644
--- a/actionpack/lib/action_dispatch/http/content_security_policy.rb
+++ b/actionpack/lib/action_dispatch/http/content_security_policy.rb
@@ -21,10 +21,7 @@ module ActionDispatch #:nodoc:
return response if policy_present?(headers)
if policy = request.content_security_policy
- built_policy = policy.build(request.controller_instance)
- if built_policy
- headers[header_name(request)] = built_policy
- end
+ headers[header_name(request)] = policy.build(request.controller_instance)
end
response
@@ -175,12 +172,7 @@ module ActionDispatch #:nodoc:
end
def build(context = nil)
- built_directives = build_directives(context).compact
- if built_directives.empty?
- nil
- else
- built_directives.join("; ") + ";"
- end
+ build_directives(context).compact.join("; ") + ";"
end
private