diff options
author | José Valim <jose.valim@gmail.com> | 2010-01-19 12:52:10 +0100 |
---|---|---|
committer | José Valim <jose.valim@gmail.com> | 2010-01-19 15:35:24 +0100 |
commit | a8e25a518ae8df1682c84affa3b986ca3627da12 (patch) | |
tree | 363327cc6832cd7b0f2727cebe6ed0c1fe30b831 /actionpack/lib/action_controller/metal | |
parent | 5a81dbf4894f112b73da160611c8be28b44c261f (diff) | |
download | rails-a8e25a518ae8df1682c84affa3b986ca3627da12.tar.gz rails-a8e25a518ae8df1682c84affa3b986ca3627da12.tar.bz2 rails-a8e25a518ae8df1682c84affa3b986ca3627da12.zip |
Move parameters to the top on logging.
Diffstat (limited to 'actionpack/lib/action_controller/metal')
-rw-r--r-- | actionpack/lib/action_controller/metal/filter_parameter_logging.rb | 5 | ||||
-rw-r--r-- | actionpack/lib/action_controller/metal/instrumentation.rb | 20 |
2 files changed, 13 insertions, 12 deletions
diff --git a/actionpack/lib/action_controller/metal/filter_parameter_logging.rb b/actionpack/lib/action_controller/metal/filter_parameter_logging.rb index 0b1e1ee6ab..9e03f50759 100644 --- a/actionpack/lib/action_controller/metal/filter_parameter_logging.rb +++ b/actionpack/lib/action_controller/metal/filter_parameter_logging.rb @@ -58,11 +58,6 @@ module ActionController protected - def append_info_to_payload(payload) - super - payload[:params] = filter_parameters(request.params) - end - def filter_parameters(params) params.dup.except!(*INTERNAL_PARAMS) end diff --git a/actionpack/lib/action_controller/metal/instrumentation.rb b/actionpack/lib/action_controller/metal/instrumentation.rb index 876f778751..7b2b037c67 100644 --- a/actionpack/lib/action_controller/metal/instrumentation.rb +++ b/actionpack/lib/action_controller/metal/instrumentation.rb @@ -9,18 +9,24 @@ module ActionController module Instrumentation extend ActiveSupport::Concern - included do - include AbstractController::Logger - end + include AbstractController::Logger + include ActionController::FilterParameterLogging attr_internal :view_runtime def process_action(action, *args) - ActiveSupport::Notifications.instrument("action_controller.process_action") do |payload| + raw_payload = { + :controller => self.class.name, + :action => self.action_name, + :params => filter_parameters(params), + :formats => request.formats.map(&:to_sym) + } + + ActiveSupport::Notifications.instrument("action_controller.start_processing", raw_payload.dup) + + ActiveSupport::Notifications.instrument("action_controller.process_action", raw_payload) do |payload| result = super - payload[:controller] = self.class.name - payload[:action] = self.action_name - payload[:status] = response.status + payload[:status] = response.status append_info_to_payload(payload) result end |