aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_controller/metal/strong_parameters.rb
diff options
context:
space:
mode:
authorXavier Noria <fxn@hashref.com>2013-12-21 01:11:47 +0100
committerXavier Noria <fxn@hashref.com>2013-12-21 01:16:38 +0100
commit92f9ff8cc325d72d74cbf839ac9ac0acd474a768 (patch)
tree041cdcdcf7ed07f8efdd1574075f47716212fff8 /actionpack/lib/action_controller/metal/strong_parameters.rb
parentfbb79b517f3127ba620fedd01849f9628b78d6ce (diff)
downloadrails-92f9ff8cc325d72d74cbf839ac9ac0acd474a768.tar.gz
rails-92f9ff8cc325d72d74cbf839ac9ac0acd474a768.tar.bz2
rails-92f9ff8cc325d72d74cbf839ac9ac0acd474a768.zip
converts hashes in arrays of unfiltered params to unpermitted params [fixes #13382]
Diffstat (limited to 'actionpack/lib/action_controller/metal/strong_parameters.rb')
-rw-r--r--actionpack/lib/action_controller/metal/strong_parameters.rb13
1 files changed, 10 insertions, 3 deletions
diff --git a/actionpack/lib/action_controller/metal/strong_parameters.rb b/actionpack/lib/action_controller/metal/strong_parameters.rb
index b4948d99a8..a3ac15a1d2 100644
--- a/actionpack/lib/action_controller/metal/strong_parameters.rb
+++ b/actionpack/lib/action_controller/metal/strong_parameters.rb
@@ -330,11 +330,18 @@ module ActionController
private
def convert_hashes_to_parameters(key, value)
- if value.is_a?(Parameters) || !value.is_a?(Hash)
+ converted = convert_value_to_parameters(value)
+ self[key] = converted unless converted.equal?(value)
+ converted
+ end
+
+ def convert_value_to_parameters(value)
+ if value.is_a?(Array)
+ value.map { |_| convert_value_to_parameters(_) }
+ elsif value.is_a?(Parameters) || !value.is_a?(Hash)
value
else
- # Convert to Parameters on first access
- self[key] = self.class.new(value)
+ self.class.new(value)
end
end