diff options
| author | Isaac Betesh <iybetesh@gmail.com> | 2019-05-09 12:38:58 -0700 |
|---|---|---|
| committer | Isaac Betesh <iybetesh@gmail.com> | 2019-05-21 13:11:19 -0700 |
| commit | efeddb08dae3dc6240118444234e3acdcfdffaa1 (patch) | |
| tree | b59746f0f24e325f6719995d2ec3ea3ca8d24cc6 /actionpack/lib/action_controller/metal/force_ssl.rb | |
| parent | 973096b6ae1f34310316a74e282501357739ac87 (diff) | |
| download | rails-efeddb08dae3dc6240118444234e3acdcfdffaa1.tar.gz rails-efeddb08dae3dc6240118444234e3acdcfdffaa1.tar.bz2 rails-efeddb08dae3dc6240118444234e3acdcfdffaa1.zip | |
Prevent reading inline attachments after `mail` was called from raising an inaccurate exception
Without this change, `attachments.inline['my_attachment'].present?`, for example,
would raise the exception `Can't add attachments after mail was called`.
I first brought this issue up at https://github.com/rails/rails/issues/16163#issuecomment-437378347.
Note that this commit addresses only one of the 2 problems I described in that comment.
The other problem is that using `attachments.inline['my_attachment']` for reading an
attachment is unnecessary--it's the same as `attachments['my_attachment']`--even before
`mail` is called. We could add a warning about the unnecessary use of `inline` but I'm
saving that for a later PR since my comment has not received any feedback yet.
Diffstat (limited to 'actionpack/lib/action_controller/metal/force_ssl.rb')
0 files changed, 0 insertions, 0 deletions