aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_controller/layout.rb
diff options
context:
space:
mode:
authorDavid Heinemeier Hansson <david@loudthinking.com>2006-03-20 04:01:10 +0000
committerDavid Heinemeier Hansson <david@loudthinking.com>2006-03-20 04:01:10 +0000
commitd19e8f412f3cbd32842f94cba11e5c1148dfd558 (patch)
tree2e58fd5e580d1479ba6cdf3a0ff9443319dcf752 /actionpack/lib/action_controller/layout.rb
parent324ece25e9c9fb13ce91e591d5c5fdd512a81bb0 (diff)
downloadrails-d19e8f412f3cbd32842f94cba11e5c1148dfd558.tar.gz
rails-d19e8f412f3cbd32842f94cba11e5c1148dfd558.tar.bz2
rails-d19e8f412f3cbd32842f94cba11e5c1148dfd558.zip
Performance speedup for ActionController (closes #4174) [Stefan Kaes] Includes caching of filter chains -- be on the lookout for problems with that!
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3989 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
Diffstat (limited to 'actionpack/lib/action_controller/layout.rb')
-rw-r--r--actionpack/lib/action_controller/layout.rb9
1 files changed, 7 insertions, 2 deletions
diff --git a/actionpack/lib/action_controller/layout.rb b/actionpack/lib/action_controller/layout.rb
index fdee677bbb..7ecff73380 100644
--- a/actionpack/lib/action_controller/layout.rb
+++ b/actionpack/lib/action_controller/layout.rb
@@ -170,7 +170,11 @@ module ActionController #:nodoc:
end
def layout_conditions #:nodoc:
- read_inheritable_attribute("layout_conditions")
+ @layout_conditions ||= read_inheritable_attribute("layout_conditions")
+ end
+
+ def default_layout #:nodoc:
+ @default_layout ||= read_inheritable_attribute("layout")
end
private
@@ -205,7 +209,7 @@ module ActionController #:nodoc:
# object). If the layout was defined without a directory, layouts is assumed. So <tt>layout "weblog/standard"</tt> will return
# weblog/standard, but <tt>layout "standard"</tt> will return layouts/standard.
def active_layout(passed_layout = nil)
- layout = passed_layout || self.class.read_inheritable_attribute("layout")
+ layout = passed_layout || self.class.default_layout
active_layout = case layout
when String then layout
@@ -249,6 +253,7 @@ module ActionController #:nodoc:
end
private
+
def apply_layout?(template_with_options, options)
return false if options == :update
template_with_options ? candidate_for_layout?(options) : !template_exempt_from_layout?