aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_controller/api
diff options
context:
space:
mode:
authorFumiaki MATSUSHIMA <mtsmfm@gmail.com>2017-11-19 02:04:38 +0900
committerFumiaki MATSUSHIMA <mtsmfm@gmail.com>2017-11-23 14:37:06 +0900
commit788c9085773a1753db31179d7ae26649979b4a01 (patch)
treecb8046e2a23943a61b9add2955c0c6baeb92cd75 /actionpack/lib/action_controller/api
parentd6338ad623bd1a8b18e61c222fbd2a9e05e2e25d (diff)
downloadrails-788c9085773a1753db31179d7ae26649979b4a01.tar.gz
rails-788c9085773a1753db31179d7ae26649979b4a01.tar.bz2
rails-788c9085773a1753db31179d7ae26649979b4a01.zip
Fix unstable test test_delegate_socket_errors_to_on_error_handler
I often face the following error when running test/connection/client_socket_test.rb: ``` $ bin/test test/connection/client_socket_test.rb:38 Run options: --seed 44035 # Running: F Failure: ActionCable::Connection::ClientSocketTest#test_delegate_socket_errors_to_on_error_handler [/app/actioncable/test/connection/client_socket_test.rb:47]: --- expected +++ actual @@ -1 +1 @@ -["foo"] +["Broken pipe", "Broken pipe", "Broken pipe", "foo"] ``` It can be reproduced easily by applying the following patch: ``` diff --git a/actioncable/test/connection/client_socket_test.rb b/actioncable/test/connection/client_socket_test.rb index 2051216010..6bb9f13ea7 100644 --- a/actioncable/test/connection/client_socket_test.rb +++ b/actioncable/test/connection/client_socket_test.rb @@ -34,7 +34,8 @@ def on_error(message) @server.config.allowed_request_origins = %w( http://rubyonrails.com ) end - test "delegate socket errors to on_error handler" do + 1000.times do |i| + test "delegate socket errors to on_error handler #{i}" do run_in_eventmachine do connection = open_connection @@ -47,6 +48,7 @@ def on_error(message) assert_equal %w[ foo ], connection.errors end end + end test "closes hijacked i/o socket at shutdown" do run_in_eventmachine do ``` The cause is writing io from different thread at the same time. `connection.process` sends handshake message from [StreamEventLoop's thread][] whereas `connection.handle_open` sends welcome message from current thread. [StreamEventLoop's thread]: https://github.com/rails/rails/blob/067fc779c4560fff4812614a2f78f9248f3e55f8/actioncable/lib/action_cable/connection/stream_event_loop.rb#L75
Diffstat (limited to 'actionpack/lib/action_controller/api')
0 files changed, 0 insertions, 0 deletions